Various small OpenPGP fixes
Categories
(MailNews Core :: Security: OpenPGP, enhancement)
Tracking
(Not tracked)
People
(Reporter: KaiE, Assigned: KaiE)
References
Details
(Keywords: leave-open)
Attachments
(2 files)
I have repeatedly the need to land small fixes to OpenPGP, and having their own bug might seem overkill. It might be a simplification to use a single tracking bug for them.
|
||
Comment 1•2 years ago
|
||
Maybe also a place to note down minor stuff.
With no key set up I get this error in the console.
[init_file_src() /home/magnus/Code/tb/mozilla/comm/third_party/rnp/src/librepgp/stream-common.cpp:391] can't stat '/home/magnus/.thunderbird/cb0srcqs.ppi/pubring.gpg'
[init_file_src() /home/magnus/Code/tb/mozilla/comm/third_party/rnp/src/librepgp/stream-common.cpp:391] can't stat '/home/magnus/.thunderbird/cb0srcqs.ppi/secring.gpg'
At some point I also get
JavaScript error: chrome://openpgp/content/modules/stdlib/misc.jsm, line 420: TypeError: can't access property "email", ac.defaultIdentity is null
|
Assignee | |
Comment 2•2 years ago
|
||
(In reply to Magnus Melin [:mkmelin] from comment #1)
With no key set up I get this error in the console.
[init_file_src() /home/magnus/Code/tb/mozilla/comm/third_party/rnp/src/librepgp/stream-common.cpp:391] can't stat '/home/magnus/.thunderbird/cb0srcqs.ppi/pubring.gpg'
[init_file_src() /home/magnus/Code/tb/mozilla/comm/third_party/rnp/src/librepgp/stream-common.cpp:391] can't stat '/home/magnus/.thunderbird/cb0srcqs.ppi/secring.gpg'
These don't indicate a problem, they are warning messages produced from inside the RNP library. I see several other kinds of messages. I've asked the RNP maintainers to make it possible to disable printing them: https://github.com/rnpgp/rnp/issues/1103
At some point I also get
JavaScript error: chrome://openpgp/content/modules/stdlib/misc.jsm, line 420: TypeError: can't access property "email", ac.defaultIdentity is null
Yes, I've also seen that. TODO
|
|
Assignee | |
Comment 3•2 years ago
|
||
With a fresh profile, I noticed a windows opened, barely noticeable, because it was zero pixels big, only the minimal border could be seen. When enlarging the window, I saw "chrome/openpgp/content/openpgp/ui/setupWizard2.xhtml cannot be found". So we still have the automatic setup wizard enabled. We need to disable that.
|
|
Assignee | |
Comment 4•2 years ago
|
||
|
|
Assignee | |
Comment 5•2 years ago
|
||
|
|
Assignee | |
Comment 6•2 years ago
|
||
Patch from comment 5 fixes the "setup wizard cannot be found popup", and also fixes "ac.defaultIdentity is null"
It removes the whole migration code for old Enigmail versions. I don't think we need that any more, and should offer migration from the most recent enigmail verison, only. If necessary we can bring parts of this code back.
Pushed by kaie@kuix.de: https://hg.mozilla.org/comm-central/rev/a432e1a57c28 Parameter type mismatch, fix public export. r=PatrickBrunschwig https://hg.mozilla.org/comm-central/rev/67ee43e49968 Remove old migration code and setup wizard. r=PatrickBrunschwig
|
|
||
Comment 8•2 years ago
|
||
Another small(?) problem
./mach test comm/mail/test/browser/composition/browser_forwardHeaders.js
JavaScript error: chrome://openpgp/content/ui/enigmailMsgComposeOverlay.js, line 1234: TypeError: can't access property "compFields", gMsgCompose is null
INFO Console message: [JavaScript Error: "TypeError: can't access property "compFields", gMsgCompose is null" {file: "chrome://openpgp/content/ui/enigmailMsgComposeOverlay.js" line: 1234}]
|
|
Assignee | |
Comment 9•2 years ago
|
||
(In reply to Magnus Melin [:mkmelin] from comment #8)
JavaScript error: chrome://openpgp/content/ui/enigmailMsgComposeOverlay.js, line 1234: TypeError: can't access property "compFields", gMsgCompose is null
Thanks. This happens if we reach ComposeProcessDone. I've added a null check in the patch for bug 1633288.
|
|
Assignee | |
Comment 10•2 years ago
|
||
(In reply to Kai Engert (:KaiE:) from comment #2)
(In reply to Magnus Melin [:mkmelin] from comment #1)
With no key set up I get this error in the console.
[init_file_src() /home/magnus/Code/tb/mozilla/comm/third_party/rnp/src/librepgp/stream-common.cpp:391] can't stat '/home/magnus/.thunderbird/cb0srcqs.ppi/pubring.gpg'
[init_file_src() /home/magnus/Code/tb/mozilla/comm/third_party/rnp/src/librepgp/stream-common.cpp:391] can't stat '/home/magnus/.thunderbird/cb0srcqs.ppi/secring.gpg'These don't indicate a problem, they are warning messages produced from inside the RNP library. I see several other kinds of messages. I've asked the RNP maintainers to make it possible to disable printing them: https://github.com/rnpgp/rnp/issues/1103
RNP snapshot from 2020-05-30 will disable those in non-debug builds.
Bug 1641612
Description
•