1631019 - Various small OpenPGP fixes

Status: RESOLVED FIXED

(MailNews Core :: Security: OpenPGP, enhancement)

Description

[Kai Engert [:KaiE:]]

I have repeatedly the need to land small fixes to OpenPGP, and having their own bug might seem overkill. It might be a simplification to use a single tracking bug for them.

Comment 1

[Magnus Melin [:mkmelin]]

Maybe also a place to note down minor stuff.

With no key set up I get this error in the console.
[init_file_src() /home/magnus/Code/tb/mozilla/comm/third_party/rnp/src/librepgp/stream-common.cpp:391] can't stat '/home/magnus/.thunderbird/cb0srcqs.ppi/pubring.gpg'
[init_file_src() /home/magnus/Code/tb/mozilla/comm/third_party/rnp/src/librepgp/stream-common.cpp:391] can't stat '/home/magnus/.thunderbird/cb0srcqs.ppi/secring.gpg'

At some point I also get
JavaScript error: chrome://openpgp/content/modules/stdlib/misc.jsm, line 420: TypeError: can't access property "email", ac.defaultIdentity is null

Comment 2

[Kai Engert [:KaiE:]]

(In reply to Magnus Melin [:mkmelin] from comment #1)

With no key set up I get this error in the console.
[init_file_src() /home/magnus/Code/tb/mozilla/comm/third_party/rnp/src/librepgp/stream-common.cpp:391] can't stat '/home/magnus/.thunderbird/cb0srcqs.ppi/pubring.gpg'
[init_file_src() /home/magnus/Code/tb/mozilla/comm/third_party/rnp/src/librepgp/stream-common.cpp:391] can't stat '/home/magnus/.thunderbird/cb0srcqs.ppi/secring.gpg'

These don't indicate a problem, they are warning messages produced from inside the RNP library. I see several other kinds of messages. I've asked the RNP maintainers to make it possible to disable printing them: https://github.com/rnpgp/rnp/issues/1103

At some point I also get
JavaScript error: chrome://openpgp/content/modules/stdlib/misc.jsm, line 420: TypeError: can't access property "email", ac.defaultIdentity is null

Yes, I've also seen that. TODO

Comment 3

[Kai Engert [:KaiE:]]

With a fresh profile, I noticed a windows opened, barely noticeable, because it was zero pixels big, only the minimal border could be seen. When enlarging the window, I saw "chrome/openpgp/content/openpgp/ui/setupWizard2.xhtml cannot be found". So we still have the automatic setup wizard enabled. We need to disable that.

Comment 4

[Kai Engert [:KaiE:]]

Attachment: Bug 1631019 - Parameter type mismatch, fix public export. r=PatrickBrunschwig

Comment 5

[Kai Engert [:KaiE:]]

Attachment: Bug 1631019 - Remove old migration code and setup wizard. r=PatrickBrunschwig

Comment 6

[Kai Engert [:KaiE:]]

Patch from comment 5 fixes the "setup wizard cannot be found popup", and also fixes "ac.defaultIdentity is null"

It removes the whole migration code for old Enigmail versions. I don't think we need that any more, and should offer migration from the most recent enigmail verison, only. If necessary we can bring parts of this code back.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a432e1a57c28
Parameter type mismatch, fix public export. r=PatrickBrunschwig
https://hg.mozilla.org/comm-central/rev/67ee43e49968
Remove old migration code and setup wizard. r=PatrickBrunschwig

Comment 8

[Magnus Melin [:mkmelin]]

Another small(?) problem
./mach test comm/mail/test/browser/composition/browser_forwardHeaders.js

JavaScript error: chrome://openpgp/content/ui/enigmailMsgComposeOverlay.js, line 1234: TypeError: can't access property "compFields", gMsgCompose is null
INFO Console message: [JavaScript Error: "TypeError: can't access property "compFields", gMsgCompose is null" {file: "chrome://openpgp/content/ui/enigmailMsgComposeOverlay.js" line: 1234}]

Comment 9

[Kai Engert [:KaiE:]]

(In reply to Magnus Melin [:mkmelin] from comment #8)

JavaScript error: chrome://openpgp/content/ui/enigmailMsgComposeOverlay.js, line 1234: TypeError: can't access property "compFields", gMsgCompose is null

Thanks. This happens if we reach ComposeProcessDone. I've added a null check in the patch for bug 1633288.

Comment 10

[Kai Engert [:KaiE:]]

(In reply to Kai Engert (:KaiE:) from comment #2)

(In reply to Magnus Melin [:mkmelin] from comment #1)

With no key set up I get this error in the console.
[init_file_src() /home/magnus/Code/tb/mozilla/comm/third_party/rnp/src/librepgp/stream-common.cpp:391] can't stat '/home/magnus/.thunderbird/cb0srcqs.ppi/pubring.gpg'
[init_file_src() /home/magnus/Code/tb/mozilla/comm/third_party/rnp/src/librepgp/stream-common.cpp:391] can't stat '/home/magnus/.thunderbird/cb0srcqs.ppi/secring.gpg'

These don't indicate a problem, they are warning messages produced from inside the RNP library. I see several other kinds of messages. I've asked the RNP maintainers to make it possible to disable printing them: https://github.com/rnpgp/rnp/issues/1103

RNP snapshot from 2020-05-30 will disable those in non-debug builds.
Bug 1641612

Comment 11

[Nicolas Falquet]

2 years later, is this vague ticket still useful?

Comment 12

[Kai Engert [:KaiE:]]

No, we should close it.