Closed Bug 1631034 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 23069 - Rework WPT: /fetch/stale-while-revalidate/stale-script.html

Categories

(Core :: DOM: Networking, task, P4)

Product:
Core
Component:
DOM: Networking
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla77
Tracking Flags:
Tracking Status
firefox77 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream][necko-triaged])

Sync web-platform-tests PR 23069 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/23069
Details from upstream follow.

arthursonzogni <arthursonzogni@chromium.org> wrote:

Rework WPT: /fetch/stale-while-revalidate/stale-script.html

Mainly for improving my own understanding. I would like to make some
tests about CSP vs stale-while-revalidate for issue 1070117

This patch:

  1. Use Promise(s) instead of callback(s). This unwrap the logic flow.

  2. Make "last_modified_count" to count the number of new version being
    served. Previously, it was a bit confusing to me.

  3. Extend the test to check the "revalidated" version is served on the
    3rd load.

  4. Small misc refactorings.

Bug: 1070117
Change-Id: Ifba23d78e539eb50262244f59e7c16e1b9ca56ab
Reviewed-on: https://chromium-review.googlesource.com/2154786
WPT-Export-Revision: cbf79ad5fc6381bf646dd677c2e96a722b47fd7e

Component: web-platform-tests → DOM: Networking
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream][necko-triaged]

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 60 tests

Status Summary

Firefox

OK : 1
PASS: 1[GitHub] 60[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt]

Chrome

OK : 1
FAIL: 1

Safari

OK : 1
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/71a431251ea1
[wpt PR 23069] - Rework WPT: /fetch/stale-while-revalidate/stale-script.html, a=testonly
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/d13606390be7
[wpt PR 23069] - Rework WPT: /fetch/stale-while-revalidate/stale-script.html, a=testonly

https://hg.mozilla.org/mozilla-central/rev/d13606390be7

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox77: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
You need to log in before you can comment on or make changes to this bug.