1631184 - Marking messages as read or flagged with browser.messages.update fails to persist for IMAP folders

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: Extensions API, defect)

Description

[Mark Banner (:standard8)]

With the browser.messages.update API, doing something like:

await browser.messages.update(m.message._id, { read: true });

works fine for locally stored messages.

However, when doing it on a message in an IMAP folder, it looks like it has been marked as read, but then when you switch folder and back again, it reverts to unread.

I think the problem is the operations are being done directly on the message header, not the folder.

Comment 1

[Mark Banner (:standard8)]

I think I have a patch for this.

Comment 2

[Mark Banner (:standard8)]

Attachment: Use folder methods rather than the header directly

This fixes it by moving away from directly setting on the header, and instead using functions on the folder - the folder functions do the necessary changes on the function as well as changing the headers.

Comment 3

[Geoff Lankow (:darktrojan)]

Comment on attachment 9141486 [details] [diff] [review]
Use folder methods rather than the header directly

Thanks Mark, that's better.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/8b801d401469
Marking messages as read or flagged with browser.messages.update fails to persist for IMAP folders. r=darktrojan

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9141486 [details] [diff] [review]
Use folder methods rather than the header directly

approved

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 76.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/e38f495e5297

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9141486 [details] [diff] [review]
Use folder methods rather than the header directly

Not long lived on beta, but no problems reported and narrow scope to addons, so approved for ESR

Comment 9

[Rob Lemley [:rjl]]

Thunderbird 68.8.0:
https://hg.mozilla.org/releases/comm-esr68/rev/e1f616a91e6b