Closed Bug 1631289 Opened 5 years ago Closed 5 years ago

Stop including preferences.css twice in preferences dialogs

Categories

(Firefox :: Settings UI, defect, P3)

Product:
Firefox
Component:
Settings UI
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 77
Tracking Flags:
Tracking Status
firefox-esr68 --- unaffected
firefox75 --- unaffected
firefox76 --- unaffected
firefox77 --- fixed

People

(Reporter: ntim, Assigned: ntim)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Bug 1631289 - Stop including preferences.css twice in preferences dialogs. r=jaws,Gijs
47 bytes, text/x-phabricator-request
Details | Review

Some dialogs include preferences.css twice:

It's annoying for debugging styles, and I suspect it's not great for perf either (though probably negligible).

I believe the dialogs that include it in their markup do this because they may be opened outside of a subdialog. subdialogs.js should check that the stylesheet isn't already in the markup before injecting it.

Priority: -- → P3
Status: NEW → RESOLVED
Closed: 5 years ago
Regressed by: 1630039
Resolution: --- → FIXED
Has Regression Range: --- → yes

Urgh, I'm really tired today.

Status: RESOLVED → REOPENED
Keywords: regression
Resolution: FIXED → ---
Status: REOPENED → NEW
Assignee: nobody → ntim.bugs
Status: NEW → ASSIGNED
Pushed by cbrindusan@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fbce36fb761f Stop including preferences.css twice in preferences dialogs. r=jaws

https://hg.mozilla.org/mozilla-central/rev/fbce36fb761f

Status: ASSIGNED → RESOLVED
Closed: 5 years ago → 5 years ago
status-firefox77: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 77
Regressions: 1640913
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: