1631314 - [wpt-sync] Sync PR 23100 - [device-orientation] Simplifies tests by using EventWatcher

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, task, P4)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 23100 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/23100
Details from upstream follow.

Wanming Lin <[e-mail]> wrote:

[device-orientation] Simplifies tests by using EventWatcher

This CL simplifies wpt/orientation-event tests by using
testharness.js' EventWatcher to replace existing customized
waitForEvent method and improving event comparison methods.

Uses setGetSensorShouldFail to simulate UA can not provide
sensor information for orientation/deviceorientationabsoluteevent.https.html,
and merges which into orientation/basic-operation-absolute.https.html.

Bug: 816462
Change-Id: Ia7bf83cb9401265722e472ccdd01adc114eff660

Reviewed-on: https://chromium-review.googlesource.com/2154389
WPT-Export-Revision: bbff35f69f6968fa011ce967c293550557a95f24

Comment 1

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

PR 23100 applied with additional changes from upstream: 4ecd8a4cf7ff9c06cba93407135173957634755c, 1e70d80274cf2d6b49e5afa768bd5b7aa3a12441, cecb2bbc14aa1b11fa1fa91ada39127df551fc12, 7649cb84f3d93e46ed2beafda0ee872ddb0b2956

Comment 2

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=b8a3186b085eb2363e90491d93791b8fea94e615

Comment 3

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 73 tests and 1 subtests

Status Summary

Firefox

OK : 14
PASS: 59
FAIL: 19

Chrome

OK : 14
PASS: 1
FAIL: 18

Safari

OK : 14
PASS: 1
FAIL: 18

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/orientation-event/device-orientation-events-unavailable-on-insecure-origins.html
Event interfaces and event handlers are not exposed on window.: FAIL

New Tests That Don't Pass

/orientation-event/orientation/add-listener-from-callback.https.html
Tests that adding a new deviceorientation event listener from a callback works as expected.: FAIL (Chrome: FAIL, Safari: FAIL)
/orientation-event/orientation/basic-operation.https.html
If UA can never provide orientation information, the event should be fired as a null event.: FAIL (Chrome: FAIL, Safari: FAIL)
Tests basic operation of deviceorientation event using mock data.: FAIL (Chrome: FAIL, Safari: FAIL)
/orientation-event/device-orientation-events-unavailable-on-insecure-origins.html
Event interfaces and event handlers are not exposed on window.: FAIL (Chrome: PASS, Safari: PASS)
addEventListener() for deviceorientationabsolute does not crash but the handler never fires.: FAIL (Chrome: FAIL, Safari: FAIL)
addEventListener() for devicemotion does not crash but the handler never fires.: FAIL (Chrome: FAIL, Safari: FAIL)
addEventListener() for deviceorientation does not crash but the handler never fires.: FAIL (Chrome: FAIL, Safari: FAIL)
/orientation-event/orientation/basic-operation-absolute.https.html
Tests basic operation of deviceorientationabsolute event using mock data.: FAIL (Chrome: FAIL, Safari: FAIL)
If UA can never provide absolute information, the event should be fired as a null event.: FAIL (Chrome: FAIL, Safari: FAIL)
/orientation-event/motion/null-values.https.html
Tests using null values for some or all of the event properties.: FAIL (Chrome: FAIL, Safari: FAIL)
/orientation-event/orientation/absolute-fallback.https.html
Tests that deviceorientation falls back to using absolute orientation data if relative is unavailable.: FAIL (Chrome: FAIL, Safari: FAIL)
/orientation-event/motion/add-during-dispatch.https.html
Test no fire listeners added during event dispatch.: FAIL (Chrome: FAIL, Safari: FAIL)
/orientation-event/motion/multiple-event-listeners.https.html
Tests using multiple event handlers for the Device Motion API.: FAIL (Chrome: FAIL, Safari: FAIL)
/orientation-event/orientation/updates.https.html
Tests that updates to the orientation causes new events to fire.: FAIL (Chrome: FAIL, Safari: FAIL)
/orientation-event/orientation/multiple-event-listeners.https.html
Tests using multiple event handlers for the Device Orientation API.: FAIL (Chrome: FAIL, Safari: FAIL)
/orientation-event/device-orientation-events-of-detached-documents.https.html
Adding an event listener on the window of a detached document does not crash.: FAIL (Chrome: FAIL, Safari: FAIL)
/orientation-event/orientation/no-synchronous-events.https.html
Tests that events are never fired synchronously from a call to window.addEventListener().: FAIL (Chrome: FAIL, Safari: FAIL)
/orientation-event/motion/add-listener-from-callback.https.html
Tests that adding a new devicemotion event listener from a callback works as expected.: FAIL (Chrome: FAIL, Safari: FAIL)
/orientation-event/orientation/null-values.https.html
Tests using null values for some of the event properties.: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a7102debdc09
[wpt PR 23100] - [device-orientation] Simplifies tests by using EventWatcher, a=testonly
https://hg.mozilla.org/integration/autoland/rev/7033320aabd2
[wpt PR 23100] - Update wpt metadata, a=testonly

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e7b48c4763c6
[wpt PR 23100] - [device-orientation] Simplifies tests by using EventWatcher, a=testonly
https://hg.mozilla.org/integration/autoland/rev/22e877bcc6c3
[wpt PR 23100] - Update wpt metadata, a=testonly

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/e7b48c4763c6
https://hg.mozilla.org/mozilla-central/rev/22e877bcc6c3