Closed Bug 1631462 Opened 4 years ago Closed 3 years ago

Wayland should be enabled in Snap package

Categories

(Release Engineering :: Release Automation: Snap, task)

Product:
Release Engineering
Component:
Release Automation: Snap
Platform:
Desktop
Linux
Type:
task

Tracking

(firefox86 wontfix, firefox87 fixed)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox86 --- wontfix
firefox87 --- fixed

People

(Reporter: max.federle, Assigned: mkaply)

References

Details

Attachments

(1 file)

Bug 1631462 - Allow Wayland to be used in the Snap. r?KenVanDine
48 bytes, text/x-phabricator-request
pascalc
: approval-mozilla-release-
Details | Review

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:75.0) Gecko/20100101 Firefox/75.0

Steps to reproduce:

  1. Install Firefox from Snap Store, any channel will do
  2. Launch Firefox in Wayland session with MOZ_ENABLE_WAYLAND=1 set

Actual results:

Firefox uses the X11 backend and runs via XWayland.
The snap specifies DISABLE_WAYLAND=1; unsetting this will still not enable the Wayland backend.

Expected results:

Firefox should be compiled with Wayland support and DISABLE_WAYLAND should be dropped from the snap package, as Wayland is an opt-in anyway.

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Component: Untriaged → Widget: Gtk
Product: Firefox → Core
Component: Widget: Gtk → Release Automation: Snap
OS: Unspecified → Linux
Product: Core → Release Engineering
QA Contact: jlorenzo
Hardware: Unspecified → Desktop
Version: 75 Branch → unspecified

I haven't tested this recently, it's very likely it can be removed now. DISABLE_WAYLAND was added quite a while back because firefox would crash on startup under wayland. In the snap, DISABLE_WAYLAND denies access to the wayland socket forcing it to fallback to XWayland.

I've just tested removing DISABLE_WAYLAND with snap try. It does indeed work. I didn't know removing DISABLE_WAYLAND after snap run --shell firefox wasn't enough.

So this does indeed only require removing DISABLE_WAYLAND, nothing else.

The DISABLE was added in: https://bugzilla.mozilla.org/show_bug.cgi?id=1425518. Seems like a trivial patch?

Severity: normal → S3
Status: UNCONFIRMED → NEW
Ever confirmed: true
Type: enhancement → task
Depends on: wayland-nightly

Should the entire patch be reverted?

https://bug1425518.bmoattachments.org/attachment.cgi?id=8937545

Or just the DISABLE_WAYLAND party?

Just drop the line with DISABLE_WAYLAND

Assignee: nobody → mozilla
Status: NEW → ASSIGNED

(In reply to Ken VanDine from comment #6)

Just drop the line with DISABLE_WAYLAND

Do you not also need the wayland plug?

Forget that. wayland's provided by gnome-3-34. I'm sorry for the noise.

Pushed by mozilla@kaply.com:
https://hg.mozilla.org/integration/autoland/rev/7c25417f9afc
Allow Wayland to be used in the Snap. r=mtabara

https://hg.mozilla.org/mozilla-central/rev/7c25417f9afc

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox87: --- → fixed
Resolution: --- → FIXED

Seeing that this change impacts only the snap package, can this revision be uplifted to the 86 RC ?

Yes. Should have done. that.

Comment on attachment 9196421 [details]
Bug 1631462 - Allow Wayland to be used in the Snap. r?KenVanDine

Beta/Release Uplift Approval Request

  • User impact if declined: Can't use Wayland on Snap
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Snap only.

We'd like to get this in 86 if possible. Sorry for not noticing.

  • String changes made/needed:
Attachment #9196421 - Flags: approval-mozilla-beta?

Yes. Should have done. that.

Ryan: wasn't sure if I request beta or release at this point. Any chance this can make RC?

Snap only, zero impact to anything else.

Flags: needinfo?(ryanvm)
Flags: needinfo?(ryanvm) → needinfo?(pascalc)

Comment on attachment 9196421 [details]
Bug 1631462 - Allow Wayland to be used in the Snap. r?KenVanDine

86 rc is already built.

Attachment #9196421 - Flags: approval-mozilla-beta? → approval-mozilla-release?

Comment on attachment 9196421 [details]
Bug 1631462 - Allow Wayland to be used in the Snap. r?KenVanDine

Mozilla doesn't ship Wayland yet officially and we are in RC week for 86, I think this can ride the 87 train.

Flags: needinfo?(pascalc)
Attachment #9196421 - Flags: approval-mozilla-release? → approval-mozilla-release-

Hello,
It seems Ubuntu 21.04 is going to be released with wayland expected to be set as the default.

A lot of users I imagine are being pushed to, or at the moment are using the snap package. Could this perhaps be reviewed and implemented as otherwise I can imagine a few people getting rather unpleasant experiences with the non-wayland snap.

Kind regards,
Krish

Flags: needinfo?(pascalc)

This fix should be in 88 and other wayland specific fixes as well:

https://bugzilla.mozilla.org/show_bug.cgi?id=1701182

Flags: needinfo?(pascalc)
Blocks: wayland-nightly
No longer depends on: wayland-nightly

Is this really fixed? Ubuntu 22.04 snap (99.0.1) runs under xwayland, or am I doing something wrong?

That's intentional, see bug 1725245.
Note that the snap in the beta channel and in the edge channel (nightly) do not have this restriction, they will run natively under Wayland.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: