1425518 - Snap: Use custom gtk3 to remove wayland support

Status: RESOLVED FIXED

(Release Engineering :: Release Automation, enhancement)

Description

[Johan Lorenzo [:jlorenzo]]

Bug 1422063 added wayland in the snap manifest, but wayland isn't supported by Firefox. Olivier Tilloy from Canonical got Firefox running on wayland by using a GTK3 that doesn't expose Wayland.

Comment 1

[Johan Lorenzo [:jlorenzo]]

Attachment: Bug 1425518 - Snap: Use custom gtk3 to remove wayland support

Review commit: https://reviewboard.mozilla.org/r/207816/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/207816/

Comment 2

[Johan Lorenzo [:jlorenzo]]

Ken and Olivier from Canonical came up with this snapcraft.yaml. I think depending on a non-official github repo is risky for actual releases. It should be okay for closed betas, though. What do you think, rail?

Comment 3

[Rail Aliiev [:rail]]

I trust their knowledge more then ours. :) Let's make it better!

Comment 4

[Rail Aliiev [:rail]]

Comment on attachment 8937120 [details]
Bug 1425518 - Snap: Use custom gtk3 to remove wayland support

https://reviewboard.mozilla.org/r/207816/#review213704

Comment 5

[Rail Aliiev [:rail]]

Comment on attachment 8937120 [details]
Bug 1425518 - Snap: Use custom gtk3 to remove wayland support

https://reviewboard.mozilla.org/r/207816/#review213706

::: taskcluster/docker/firefox-snap/snapcraft.yaml.in:46
(Diff revision 1)
>        - libmirclient9
> -    after: [desktop-gtk3]
> +    after: [desktop-gtk3-no-wayland]
> +  desktop-gtk3-no-wayland:
> +    # Use a custom branch of the desktop helpers instead of the upstream one,
> +    # to disable wayland (not supported natively by firefox).
> +    source: https://github.com/oSoMoN/snapcraft-desktop-helpers.git

Just realized that this repo is a fork of https://github.com/Ubuntu/snapcraft-desktop-helpers. Can we use the original instead? Otherwisewe may end up with outdated tools.

Comment 6

[Ken VanDine]

Attachment: updated snapcraft.yaml.in which uses the official upstream desktop-gtk3 launcher

Updated snapcraft.yaml.in which uses the supported desktop-gtk3 launcher.  We've merged a fix in snapcrafters-desktop-helpers to better handle disabling wayland via an environment variable.  The attached snapcraft.yaml.in sets the DISABLE_WAYLAND environment variable and uses the officially supported helpers instead of the developer's branch.

Comment 7

[Rail Aliiev [:rail]]

Attachment: DISABLE_WAYLAND.diff

Ken, thank you for the updated snapcraft.yml! Attaching the diff against the current mozilla-central version here.

Unfortunately we just missed today's beta build, so we'll have to wait until the next one (early January).

I'll let Johan land the patch and uplift it to beta, because I'll be away in January.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6f48edc3e633
Snap: remove wayland support r=mtabara DONTBUILD

Comment 9

[Rail Aliiev [:rail]]

Beta: https://hg.mozilla.org/releases/mozilla-beta/rev/11ba3450c3362d8778864d1254604042fdc8b603

Comment 10

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/6f48edc3e633