1631463 - web-ext fails to install extension on GeckoView app

Status: RESOLVED FIXED

(DevTools :: about:debugging, defect)

Description

[Eugen Sawin [:esawin]]

STR:
Try to run a local extension on GVE via web-ext run --target=firefox-android --firefox-apk=org.mozilla.geckoview_example --firefox-apk-component=GeckoViewActivity --android-device=<id>

Expected: Extension installs and runs.

Actual:

c: This is an older version of Firefox that does not provide an add-ons actor for remote installation. Try Firefox 49 or higher.
    at client.request (/usr/local/lib/node_modules/web-ext/dist/web-ext.js:1:5757)
    at /usr/local/lib/node_modules/web-ext/node_modules/@cliqz-oss/firefox-client/lib/client-methods.js:82:9
    at Client.handleMessage (/usr/local/lib/node_modules/web-ext/node_modules/@cliqz-oss/firefox-client/lib/client.js:162:7)
    at Client.readMessage (/usr/local/lib/node_modules/web-ext/node_modules/@cliqz-oss/firefox-client/lib/client.js:221:10)
    at Client.onData (/usr/local/lib/node_modules/web-ext/node_modules/@cliqz-oss/firefox-client/lib/client.js:187:16)
    at Socket.emit (events.js:189:13)
    at addChunk (_stream_readable.js:284:12)
    at readableAddChunk (_stream_readable.js:265:11)
    at Socket.Readable.push (_stream_readable.js:220:10)
    at TCP.onStreamRead [as onread] (internal/stream_base_commons.js:94:17)

Comment 1

[[ex-Mozilla] Agi Sferro | :agi]

15:47.08 INFO: Last good revision: 225c5d7a7bface2cc607c030d9ff11a54f0164fd
15:47.08 INFO: First bad revision: c9502ace44dc09842ca2935db5ba8aba7dadbf4e
15:47.08 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=225c5d7a7bface2cc607c030d9ff11a54f0164fd&tochange=c9502ace44dc09842ca2935db5ba8aba7dadbf4e

:jdescottes could you take a look? web-ext is really important for us :)

cc rpl who knows about web-ext

Comment 2

[[ex-Mozilla] Agi Sferro | :agi]

Reverting this fixes the problem for me https://hg.mozilla.org/integration/autoland/rev/57c00207e4bcc8d8fe67a15e2419112764e6b539

Comment 3

[Luca Greco [:rpl] [:luca] [:lgreco]]

We are going to fix this on the web-ext side, the issue is tracked by mozilla/web-ext#1884.
mozilla/web-ext#1886 is the pull request with the fix we are going to land (we will release it in a new web-ext version pretty soon).

Comment 4

[Julian Descottes [:jdescottes]]

We treat RDP and DevTools actors as an internal API at the moment, so it can break really easily since we don't really track what 3rd party tools rely on. On the GH issue I mentioned adding tests for the APIs you use directly in m-c. I will file a bug to do that.

Adding a ni? on myself to close this when the PR is merged.

Comment 5

[Luca Greco [:rpl] [:luca] [:lgreco]]

Hi Julian,
I'm clearing your needinfo to let you know that we released the fix on npm as part of web-ext 4.2.0.

Comment 6

[Luca Greco [:rpl] [:luca] [:lgreco]]

I'm assigning this issue to Rob (because he created the pull request to fix it on the web-ext side).

Comment 7

[Luca Greco [:rpl] [:luca] [:lgreco]]

Closing as fixed.

Comment 8

[Julian Descottes [:jdescottes]]

thanks for the bugzilla cleanup Luca!