1618691 - Start using the tab descriptor in about:debugging

Status: RESOLVED FIXED

(DevTools :: about:debugging, task, P3)

Description

[Julian Descottes [:jdescottes]]

Follow up to Bug 1579042.

Now that we can have tab descriptors, we should start using descriptors instead of targets in about:debugging. As a first step we can start relying on the descriptor's form to build the UI and ultimately we can just skip getting the targets completely (and only get them when opening the toolbox)

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1618691 - Use tab descriptor in about:debugging

Depends on D65398

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1618691 - Use tab descriptor in about:debugging (TabDescriptorMock WIP)

Depends on D65398

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1618691 - Remove < FF75 backward compatibility code for getProcess

Comment 4

[Julian Descottes [:jdescottes]]

Attachment: Bug 1618691 - Remove < FF75 backward compatibility code for getTab and listTabs

Depends on D69542

Comment 5

[Julian Descottes [:jdescottes]]

Attachment: Bug 1618691 - Return selected as property of the TabDescriptorActor form

Depends on D69543
There are no actual call sites for selected, but we have a test checking the feature.
Alternatively we could get rid of the feature.

Comment 6

[Julian Descottes [:jdescottes]]

Attachment: Bug 1618691 - Stop returning selected tab information in listTabs

Depends on D69544
Since selected is read on the descriptor form, there is no need to include it in the listTabs response.

Comment 7

[Julian Descottes [:jdescottes]]

Attachment: Bug 1618691 - Simplify RootActor::listTabs response

Depends on D65693

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bb99b5f24bfe
Remove < FF75 backward compatibility code for getProcess r=ochameau
https://hg.mozilla.org/integration/autoland/rev/57c00207e4bc
Remove < FF75 backward compatibility code for getTab and listTabs r=ochameau
https://hg.mozilla.org/integration/autoland/rev/e3025878bda1
Return selected as property of the TabDescriptorActor form r=ochameau
https://hg.mozilla.org/integration/autoland/rev/3f8d60253ea9
Stop returning selected tab information in listTabs r=ochameau
https://hg.mozilla.org/integration/autoland/rev/25435d091261
Use tab descriptor in about:debugging r=ochameau
https://hg.mozilla.org/integration/autoland/rev/c9502ace44dc
Simplify RootActor::listTabs response r=ochameau

Comment 9

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/bb99b5f24bfe
https://hg.mozilla.org/mozilla-central/rev/57c00207e4bc
https://hg.mozilla.org/mozilla-central/rev/e3025878bda1
https://hg.mozilla.org/mozilla-central/rev/3f8d60253ea9
https://hg.mozilla.org/mozilla-central/rev/25435d091261
https://hg.mozilla.org/mozilla-central/rev/c9502ace44dc

Comment 14

[William Durand [:willdurand]]

:jdescottes hey, one of the patches related to this bug breaks our web-ext tool. We documented the issue in our tracker here: https://github.com/mozilla/web-ext/issues/1884, could you please take a look and help us find a more suitable way to retrieve the addonsActor? Thanks!

Comment 15

[Julian Descottes [:jdescottes]]

replied on the GH issue!