1631577 - Cannot delete entries within Customize Headers

Status: RESOLVED FIXED

(Thunderbird :: Search, defect, P2)

Description

[bug.zilla]

Hi,

I added a few custom headers to search for some messages.
I'm now unable to delete those entries from the drop-down menu.

If I select Remove from the Customise Headers menu they disappear, but once I click OK they reappear in the drop down menu options again.

I've tried in Safe Mode as well.

Comment 1

[Magnus Melin [:mkmelin]]

I can confirm this is broken.

Comment 2

[Magnus Melin [:mkmelin]]

Should be somewhere around here: https://searchfox.org/comm-central/rev/1e852ca98a90f42c6dcab821fec4c0f1124b0953/mailnews/base/search/content/CustomHeaders.js#61 - probably broken by de-xbl

Comment 3

[Khushil Mistry [:khushil324]]

Attachment: Bug-1631577-fix-delete-custom-headers-0.patch

Comment 4

[Magnus Melin [:mkmelin]]

Comment on attachment 9147731 [details] [diff] [review]
Bug-1631577-fix-delete-custom-headers-0.patch

Review of attachment 9147731 [details] [diff] [review]:
-----------------------------------------------------------------

::: mailnews/base/search/content/CustomHeaders.js
@@ +163,5 @@
>  }
>  
>  function GetListItemAttributeStr(listitem) {
>    if (listitem) {
> +    return TrimString(listitem.firstChild.getAttribute("value"));

I think this should be firstElementChild to be sure

And while we're here, let's just use normal trim().

listitem.firstElementChild.getAttribute("value").trim();

Oh, and GetListItemAttributeStr is only ever called one time. Never with null. 
Let's just inline the call instead...

Comment 5

[Khushil Mistry [:khushil324]]

Attachment: Bug-1631577-fix-delete-custom-headers-1.patch

Comment 6

[Khushil Mistry [:khushil324]]

We need to land it for ESR 68 as well as Daily.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/03319b23c7f9
Fix Cannot delete entries within Customize Headers. r=mkmelin

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9147768 [details] [diff] [review]
Bug-1631577-fix-delete-custom-headers-1.patch

approved for beta

Comment 9

[Geoff Lankow (:darktrojan)]

77.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/d09a306ef3a070a0acb80be27d36e8908ba31c9a

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9147768 [details] [diff] [review]
Bug-1631577-fix-delete-custom-headers-1.patch

[Triage Comment]
Approved for ESR

Comment 11

[Rob Lemley [:rjl]]

Thunderbird 68.9.0:
https://hg.mozilla.org/releases/comm-esr68/rev/b333ec36c423