1631684 - Replace MOZ_MUST_USE with [[nodiscard]] in dom/indexedDB

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, task, P3)

Description

[Chris Peterson [:cpeterson]]

The MOZ_MUST_USE macro is defined as clang's and gcc's nonstandard attribute((warn_unused_result)). Now that we compile as C++17 by default (bug 1560664), we can replace MOZ_MUST_USE with C++17's standard [[nodiscard]] attribute.

Also move MOZ_MUST_USE before function declarations' specifiers and return type. While clang and gcc's attribute((warn_unused_result)) can appear before, between, or after function specifiers and return types, the [[nodiscard]] attribute must precede the function specifiers.

Comment 1

[Chris Peterson [:cpeterson]]

Attachment: Bug 1631684 - Replace MOZ_MUST_USE with [[nodiscard]] in dom/indexedDB. r=sg

Also move MOZ_MUST_USE before function declarations' specifiers and return type. While clang and gcc's attribute((warn_unused_result)) can appear before, between, or after function specifiers and return types, the [[nodiscard]] attribute must precede the function specifiers.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6bbecc3020b7
Replace MOZ_MUST_USE with [[nodiscard]] in dom/indexedDB. r=dom-workers-and-storage-reviewers,sg

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d8eecc663784
acked out changeset 6bbecc3020b7 for build bustage in bindings/IDBObjectStoreBinding.cpp. CLOSED TREE

Comment 4

[Dorel Luca [:dluca]]

Backed out changeset 6bbecc3020b7 (bug 1631684) for build bustage in bindings/IDBObjectStoreBinding.cpp. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=298774040&repo=autoland&lineNumber=22784

Push with backout:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=6bbecc3020b7a4787559a5b1d167df46d59d232a&selectedJob=298774040

Backout:
https://hg.mozilla.org/integration/autoland/rev/d8eecc663784c8463af1d2bc3f91f8078c7e1940

Chris: Can you please open the revision on phabricator? I deleted the b from backout in the commit message and the system didn't opened it automatically because of that.

Comment 5

[Chris Peterson [:cpeterson]]

(In reply to Dorel Luca [:dluca] from comment #4)

Chris: Can you please open the revision on phabricator? I deleted the b from backout in the commit message and the system didn't opened it automatically because of that.

Sure. I reopened revision:
https://phabricator.services.mozilla.com/D71713#2186118

The build broke after a bad merge conflict resolution. I'll double-check the build on Try before re-landing.

Comment 6

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/6bbecc3020b7
https://hg.mozilla.org/mozilla-central/rev/d8eecc663784

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2d3187f93185
Replace MOZ_MUST_USE with [[nodiscard]] in dom/indexedDB. r=dom-workers-and-storage-reviewers,sg

Comment 8

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/2d3187f93185