1631844 - Add pinned site badge to pinned Top Sites in the Urlbar

Status: VERIFIED FIXED

(Firefox :: Address Bar, enhancement, P1)

Description

[Harry Twyford]

When Top Sites are shown in the Urlbar, we'd like to add a badge to the favicon of pinned Top Sites, similar to the badge we show for bookmarks and open/remote tabs. This will give users more clarity on why certain sites are appearing in Urlbar Top Sites. The badge priority will be pinned > open tab > bookmark.

Verdi is finalizing a design spec for this.

Comment 1

[Marco Bonardo [:mak]]

if possible (depending on design time) we'd like to have this in 77.

Comment 2

[Harry Twyford]

Attachment: Bug 1631844 - Add pinned site badge to pinned Top Sites in the Urlbar. r?dao

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4ff0cbc3329c
Add pinned site badge to pinned Top Sites in the Urlbar. r=dao

Comment 4

[Daniel Varga [:dvarga]]

Backed out changeset 4ff0cbc3329c (bug 1631844) for causing browser-chrome failures at browser/components/urlbar/tests/browser/browser_top_sites.js

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=4ff0cbc3329c7e4ed749d14f7403b79122805f7a

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=299567091&repo=autoland&lineNumber=2550

Backout link: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=299567091&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=e398ac9b8706e6ea3ddfe2b12da6dec36e91b826

[task 2020-04-27T14:05:47.042Z] 14:05:47     INFO - TEST-PASS | browser/components/urlbar/tests/browser/browser_top_sites.js | The example.com Top Site should be an open tab result. - 4 == 4 - 
[task 2020-04-27T14:05:47.043Z] 14:05:47     INFO - Buffered messages finished
[task 2020-04-27T14:05:47.043Z] 14:05:47     INFO - TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/browser/browser_top_sites.js | The example.com Top Site should be displayed as a pinned site. - "" == "true" - JS frame :: chrome://mochitests/content/browser/browser/components/urlbar/tests/browser/browser_top_sites.js :: topSitesPinned :: line 287
[task 2020-04-27T14:05:47.043Z] 14:05:47     INFO - Stack trace:
[task 2020-04-27T14:05:47.044Z] 14:05:47     INFO - chrome://mochitests/content/browser/browser/components/urlbar/tests/browser/browser_top_sites.js:topSitesPinned:287
[task 2020-04-27T14:05:47.044Z] 14:05:47     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1039
[task 2020-04-27T14:05:47.044Z] 14:05:47     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1074
[task 2020-04-27T14:05:47.044Z] 14:05:47     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:904
[task 2020-04-27T14:05:47.045Z] 14:05:47     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:918
[task 2020-04-27T14:05:47.045Z] 14:05:47     INFO - Leaving test bound topSitesPinned
[task 2020-04-27T14:05:47.046Z] 14:05:47     INFO - Entering test bound topSitesDisabled

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dea6be0b8fc0
Add pinned site badge to pinned Top Sites in the Urlbar. r=dao

Comment 6

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/dea6be0b8fc0

Comment 7

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

I can confirm this enhancement is implemented. I verified using Fx 78.0a1 (2020-05-20), on Windows 10 x64 and macOS 10.13.6.