Closed Bug 1631850 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 23145 - Initialize start time of scroll animations to zero.

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox77 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla77
Tracking Flags:
Tracking Status
firefox77 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 23145 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/23145
Details from upstream follow.

Olga Gerchikov <gerchiko@microsoft.com> wrote:

Initialize start time of scroll animations to zero.

Implemented web-animations-1 spec changes introduces in [1].

  • Update play and pause procedures to initialize start time of scroll
    animations to zero.
  • Updated calculate play state procedure to return "running" state for
    animations that has start time resolved.
  • Added/modified tests reflecting spec changes.

[1] https://github.com/w3c/csswg-drafts/pull/4842

Bug: 1070637
Change-Id: Ic83995899b2f3f8d8f985f84b8a2b438bbad7c35
Reviewed-on: https://chromium-review.googlesource.com/2150687
WPT-Export-Revision: 1f461c19d2a6fc2830038e9a843a50ca8c429c97

PR 23145 applied with additional changes from upstream: 63695b3eadcbbcb673a88e0150bea906d6dda39a

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 82 tests

Status Summary

Firefox

OK : 12
PASS : 18[GitHub] 82[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt]
FAIL : 85
TIMEOUT: 6

Chrome

OK : 11
PASS : 69
FAIL : 39
TIMEOUT: 2

Safari

OK : 12
PASS : 18
FAIL : 85
TIMEOUT: 6

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/scroll-animations/setting-current-time.html
Set animation current time to a value beyond effect end.: FAIL (Chrome: PASS, Safari: FAIL)
Set animation current time to a negative value.: FAIL (Chrome: PASS, Safari: FAIL)
Set animation current time to a valid value while playing.: FAIL (Chrome: PASS, Safari: FAIL)
Setting animation current time to null throws TypeError.: FAIL (Chrome: PASS, Safari: FAIL)
Animation current time set while the timeline is inactive holds when the timeline becomes active again.: FAIL (Chrome: PASS, Safari: FAIL)
Animation current time and play state are correct when current time is set while the timeline is inactive.: FAIL (Chrome: PASS, Safari: FAIL)
Setting animation.currentTime then restarting the animation should reset the current time.: FAIL (Chrome: PASS, Safari: FAIL)
Set animation current time to a valid value without playing.: FAIL (Chrome: PASS, Safari: FAIL)
Setting current time while play pending overrides the current time: FAIL (Chrome: PASS, Safari: FAIL)
Set Animation current time then scroll.: FAIL (Chrome: PASS, Safari: FAIL)
/scroll-animations/current-time-writing-modes.html
currentTime handles startScrollOffset with direction: rtl correctly: FAIL (Chrome: PASS, Safari: FAIL)
currentTime handles direction: rtl correctly: FAIL (Chrome: PASS, Safari: FAIL)
currentTime handles endScrollOffset with direction: rtl correctly: FAIL (Chrome: PASS, Safari: FAIL)
currentTime handles writing-mode: vertical-rl correctly: FAIL (Chrome: PASS, Safari: FAIL)
currentTime handles writing-mode: vertical-lr correctly: FAIL (Chrome: PASS, Safari: FAIL)
currentTime handles endScrollOffset (inclusive case) with direction: rtl correctly: FAIL (Chrome: PASS, Safari: FAIL)
/scroll-animations/animation-with-display-none.html: TIMEOUT (Chrome: PASS, Safari: TIMEOUT)
/scroll-animations/scroll-animation-inactive-timeline.html
Animation start and current times are correct if scroll timeline is activated after animation.play call.: FAIL (Chrome: PASS, Safari: FAIL)
oncancel event is fired when the timeline is inactive.: FAIL (Chrome: TIMEOUT, Safari: FAIL)
Play pending task doesn't run when the timeline is inactive.: FAIL (Chrome: FAIL, Safari: FAIL)
Animation current time is correct when the timeline becomes newly inactive and then active again.: FAIL (Chrome: FAIL, Safari: FAIL)
/scroll-animations/animation-with-transform.html: TIMEOUT (Chrome: PASS, Safari: TIMEOUT)
/scroll-animations/scroll-animation.html
Finished animation plays on reverse scrolling.: FAIL (Chrome: PASS, Safari: FAIL)
Animation start and current times are correct for each animation state when the animation starts playing with advanced scroller.: FAIL (Chrome: FAIL, Safari: FAIL)
Animation start and current times are correct when multiple animations are attached to the same timeline.: FAIL (Chrome: FAIL, Safari: FAIL)
Animation start and current times are correct for each animation state.: FAIL (Chrome: FAIL, Safari: FAIL)
Sending animation finished events by finished animation on reverse scrolling.: FAIL (Chrome: PASS, Safari: FAIL)
/scroll-animations/scroll-timeline-phases.tentative.html
Timeline phase while start offset is equal to end offset and scroll offset is before start: FAIL (Chrome: PASS, Safari: FAIL)
Timeline phase while scroll offset is at start: FAIL (Chrome: PASS, Safari: FAIL)
Timeline phase while scroll offset is at end: FAIL (Chrome: PASS, Safari: FAIL)
Timeline phase while start offset is greater than end offset and scroll offset is before end: FAIL (Chrome: PASS, Safari: FAIL)
Timeline phase while start offset is greater than end offset and scroll offset is at end: FAIL (Chrome: PASS, Safari: FAIL)
Timeline phase while start offset is greater than end offset and scroll offset is at start: FAIL (Chrome: PASS, Safari: FAIL)
Timeline phase while start offset is greater than end offset and scroll offset is after start: FAIL (Chrome: PASS, Safari: FAIL)
Scroll timeline starts inactive, can transition to active, and then back to inactive.: FAIL (Chrome: PASS, Safari: FAIL)
Timeline phase while scroll offset is in range: FAIL (Chrome: PASS, Safari: FAIL)
Timeline phase while scroll offset is before start: FAIL (Chrome: PASS, Safari: FAIL)
Setting scroll timeline phase (which is readonly) throws TypeError.: FAIL (Chrome: PASS, Safari: FAIL)
Timeline phase while scroll offset is after end: FAIL (Chrome: PASS, Safari: FAIL)
Timeline phase while start offset is equal to end offset and scroll offset is after end: FAIL (Chrome: PASS, Safari: FAIL)
Timeline phase while start offset is equal to end offset and scroll offset is at both: FAIL (Chrome: PASS, Safari: FAIL)
Timeline phase while start offset is greater than end offset and scroll offset is before start: FAIL (Chrome: PASS, Safari: FAIL)
/scroll-animations/animation-with-root-scroller.html: TIMEOUT (Chrome: PASS, Safari: TIMEOUT)
/scroll-animations/current-time-root-scroller.html
currentTime calculates the correct time for a document.scrollingElement scrollSource: FAIL (Chrome: PASS, Safari: FAIL)
/scroll-animations/setting-playback-rate.html
Zero current time is not affected by playbackRate set while the animation is in play-pending state.: FAIL (Chrome: PASS, Safari: FAIL)
Initial current time is scaled by playbackRate set while scroll-linked animation is in running state.: FAIL (Chrome: PASS, Safari: FAIL)
The current time is not affected by playbackRate set while the scroll-linked animation is in play state.: FAIL (Chrome: PASS, Safari: FAIL)
Reversing the playback rate while playing correctly impacts current time during future scrolls: FAIL (Chrome: PASS, Safari: FAIL)
Setting the playback rate while playing preserves the current time from scrollTimeline.: FAIL (Chrome: PASS, Safari: FAIL)
Zero initial playback rate should correctly modify initial current time.: FAIL (Chrome: PASS, Safari: FAIL)
The playback rate affects the rate of progress of the current time when scrolling: FAIL (Chrome: PASS, Safari: FAIL)
Setting the playback rate while play-pending preserves the set current time.: FAIL (Chrome: PASS, Safari: FAIL)
Setting the playback rate while play-pending preserves the current time from scrollTimeline.: FAIL (Chrome: PASS, Safari: FAIL)
Zero current time is not affected by playbackRate set while the animation is in idle state.: FAIL (Chrome: PASS, Safari: FAIL)
The playback rate set before scroll-linked animation started playing affects the rate of progress of the current time: FAIL (Chrome: PASS, Safari: FAIL)
Negative initial playback rate should correctly modify initial current time.: FAIL (Chrome: PASS, Safari: FAIL)
Setting a zero playback rate while running preserves the current time: FAIL (Chrome: PASS, Safari: FAIL)
Setting the playback rate while playing preserves the set current time.: FAIL (Chrome: PASS, Safari: FAIL)
/scroll-animations/two-animations-attach-to-same-scroll-timeline-cancel-one.html: TIMEOUT (Chrome: PASS, Safari: TIMEOUT)
/scroll-animations/element-based-offset.html
Animation start and current times are correct given
element-based offsets for orienation horizontal and with end edge and threshold 1.0.: FAIL (Chrome: FAIL, Safari: FAIL)
Animation start and current times are correct given
element-based offsets for orienation vertical and with end edge.: FAIL (Chrome: FAIL, Safari: FAIL)
Animation start and current times are correct given
element-based offsets for orienation horizontal and at start.: FAIL (Chrome: FAIL, Safari: FAIL)
Animation start and current times are correct given
element-based offsets for orienation horizontal and after end.: FAIL (Chrome: FAIL, Safari: FAIL)
Animation start and current times are correct given
element-based offsets for orienation horizontal and at middle.: FAIL (Chrome: FAIL, Safari: FAIL)
Animation start and current times are correct given
element-based offsets for orienation horizontal and with threshold 0.5.: FAIL (Chrome: FAIL, Safari: FAIL)
Animation start and current times are correct given
element-based offsets for orienation vertical and after start.: FAIL (Chrome: FAIL, Safari: FAIL)
Animation start and current times are correct given
element-based offsets for orienation horizontal and after start.: FAIL (Chrome: FAIL, Safari: FAIL)
Animation start and current times are correct given
element-based offsets for orienation vertical and at end.: FAIL (Chrome: FAIL, Safari: FAIL)
Animation start and current times are correct given
element-based offsets for orienation horizontal and with end edge.: FAIL (Chrome: FAIL, Safari: FAIL)
Animation start and current times are correct given
element-based offsets for orienation horizontal and with threshold 1.0.: FAIL (Chrome: FAIL, Safari: FAIL)
Animation start and current times are correct given
element-based offsets for orienation vertical and with threshold 0.5.: FAIL (Chrome: FAIL, Safari: FAIL)
Animation start and current times are correct given
element-based offsets for orienation vertical and at start.: FAIL (Chrome: FAIL, Safari: FAIL)
Animation start and current times are correct given
element-based offsets for orienation vertical and with end edge and threshold 1.0.: FAIL (Chrome: FAIL, Safari: FAIL)
Animation start and current times are correct given
element-based offsets for orienation vertical and with threshold 1.0.: FAIL (Chrome: FAIL, Safari: FAIL)
Animation start and current times are correct given
element-based offsets for orienation vertical and after end.: FAIL (Chrome: FAIL, Safari: FAIL)
Animation start and current times are correct given
element-based offsets for orienation vertical and at middle.: FAIL (Chrome: FAIL, Safari: FAIL)
Animation start and current times are correct given
element-based offsets for orienation horizontal and at end.: FAIL (Chrome: FAIL, Safari: FAIL)
/scroll-animations/two-animations-attach-to-same-scroll-timeline.html: TIMEOUT (Chrome: PASS, Safari: TIMEOUT)
/web-animations/timing-model/animations/setting-the-timeline-of-an-animation.html
After setting timeline on an idle animation with a start time it is running: FAIL (Chrome: FAIL, Safari: FAIL)
After setting timeline on an idle animation with a sufficiently ancient start time it is finished: FAIL (Chrome: FAIL, Safari: FAIL)
/scroll-animations/current-time.html
currentTime handles startScrollOffset and endScrollOffset together correctly: FAIL (Chrome: PASS, Safari: FAIL)
currentTime handles startScrollOffset correctly: FAIL (Chrome: PASS, Safari: FAIL)
currentTime calculates the correct time based on scrolled amount: FAIL (Chrome: PASS, Safari: FAIL)
currentTime handles endScrollOffset correctly: FAIL (Chrome: PASS, Safari: FAIL)
currentTime handles startScrollOffset > endScrollOffset correctly: FAIL (Chrome: PASS, Safari: FAIL)
currentTime adjusts correctly for the timeRange: FAIL (Chrome: PASS, Safari: FAIL)
currentTime handles startScrollOffset == endScrollOffset correctly: FAIL (Chrome: PASS, Safari: FAIL)
/scroll-animations/scroll-timeline-invalidation.html
If scroll animation resizes its scroll timeline scroller, layout runs only once to reflect the initial update.: FAIL (Chrome: PASS, Safari: FAIL)
Animation current time and effect local time are updated after scroller size changes.: FAIL (Chrome: PASS, Safari: FAIL)
Animation current time and effect local time are updated after scroller content size changes.: FAIL (Chrome: PASS, Safari: FAIL)
/scroll-animations/animation-with-overflow-hidden.html: TIMEOUT (Chrome: PASS, Safari: TIMEOUT)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8082006b8431 [wpt PR 23145] - Initialize start time of scroll animations to zero., a=testonly https://hg.mozilla.org/integration/autoland/rev/9c528be6bc57 [wpt PR 23145] - Update wpt metadata, a=testonly
Pushed by archaeopteryx@coole-files.de: https://hg.mozilla.org/integration/autoland/rev/e563517d3d93 [wpt PR 23145] - Initialize start time of scroll animations to zero., a=testonly https://hg.mozilla.org/integration/autoland/rev/44614eef394b [wpt PR 23145] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/e563517d3d93
https://hg.mozilla.org/mozilla-central/rev/44614eef394b

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox77: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
You need to log in before you can comment on or make changes to this bug.