1631973 - [wpt-sync] Sync PR 23157 - bluetooth: Split bluetooth-helpers.js

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 23157 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/23157
Details from upstream follow.

Ovidio Henriquez <[e-mail]> wrote:

bluetooth: Split bluetooth-helpers.js

This change splits the bluetooth-helpers.js files in two. The new
bluetooth-test.js file contains methods for setting up the web tests and
for asserting conditions. The bluetooth-helpers.js file now contains
helper methods that set up fake Bluetooth devices for use in the Web
Bluetooth tests.

I added JsDoc style comments to the helper methods to make it clear
what kinds of objects are expected as parameters and what the methods
will return. I also reordered the bluetooth-helpers.js methods so that
they are defined before they are used.

Bug: 1070816
Change-Id: Ib5215555be2b24b11f8dea9098d83ad69719a284
Reviewed-on: https://chromium-review.googlesource.com/2149909
WPT-Export-Revision: ea96662d43b3474182f14bd8930905fdf3ee22dc

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=6aa5d0a54ad2af9da9f5450c9331b8c7eef196ff

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Attachment: Notable wpt changes

# CI Results

Ran 7 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 229 tests

## Status Summary

### Firefox
OK     : 153
PASS   : 64
FAIL   : 154
TIMEOUT: 12
ERROR  : 12

### Chrome
OK     : 165
PASS   : 2
FAIL   : 164

### Safari
OK     : 153
FAIL   : 154
TIMEOUT: 12
ERROR  : 12

## Links
[Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=6aa5d0a54ad2af9da9f5450c9331b8c7eef196ff)
[GitHub PR Head](https://wpt.fyi/results/?sha=799900aae3af8125eea3f8b9419d7b1dcc51a6a7&label=pr_head)
[GitHub PR Base](https://wpt.fyi/results/?sha=799900aae3af8125eea3f8b9419d7b1dcc51a6a7&label=pr_base)

## Details

(See attachment for full changes)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/45cdd5e23485
[wpt PR 23157] - bluetooth: Split bluetooth-helpers.js, a=testonly

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4ef42579cac5
[wpt PR 23157] - bluetooth: Split bluetooth-helpers.js, a=testonly

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/4ef42579cac5