1631997 - Compute the NeedsFunctionEnvironmentObjects flag in parser

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Description

[Ted Campbell [:tcampbell]]

The NeedsFunctionEnvironmentObjects script flag can be computed in the parser for both lazy and non-lazy scripts if we use the ParseContext::Scope binding data.

Comment 1

[Ted Campbell [:tcampbell]]

Attachment: Bug 1631997 - Remove the MarkAllBindingsClosedOver mechanism

This is no longer needed now that legacy generators are not supported and we
know that a function is async/generator from the start.

Comment 2

[Ted Campbell [:tcampbell]]

Attachment: Bug 1631997 - Compute NeedsFunctionEnvironmentObjects flag in Parser

This computes the NeedsFunctionEnvironmentObjects flag in Parser by computing
the equivilent to the needsCallObject and needsNamedLambdaEnvironment
conditions using the parse-scope data.

Depends on D71857

Comment 3

[Ted Campbell [:tcampbell]]

Attachment: Bug 1631997 - Cleanup computation of FunctionHasExtraBodyVarScope

Be more consistent with the previous patch and tighten asserts.

Depends on D71858

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4a92d7bb22ae
Remove the MarkAllBindingsClosedOver mechanism r=arai
https://hg.mozilla.org/integration/autoland/rev/4c7821f84bf5
Compute NeedsFunctionEnvironmentObjects flag in Parser r=arai,mgaudet
https://hg.mozilla.org/integration/autoland/rev/e6df6f244ce8
Cleanup computation of FunctionHasExtraBodyVarScope r=arai

Comment 5

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/4a92d7bb22ae
https://hg.mozilla.org/mozilla-central/rev/4c7821f84bf5
https://hg.mozilla.org/mozilla-central/rev/e6df6f244ce8