Closed Bug 1632167 Opened 3 years ago Closed 1 year ago

Crash in [@ RtlAcquireSRWLockExclusive | mozilla::wr::RenderThread::RegisterExternalImage]

Categories

(Core :: Graphics: WebRender, defect, P3)

Unspecified
Windows 10
defect

Tracking

()

RESOLVED WORKSFORME
Tracking Status
firefox-esr68 --- unaffected
firefox75 --- unaffected
firefox76 --- unaffected
firefox77 --- affected

People

(Reporter: sg, Assigned: kvark)

References

(Blocks 1 open bug)

Details

(Keywords: crash)

Crash Data

This bug is for crash report bp-bfc075e0-8f7c-4c28-aa70-4b4390200422.

Top 10 frames of crashing thread:

0 ntdll.dll RtlAcquireSRWLockExclusive 
1 xul.dll mozilla::wr::RenderThread::RegisterExternalImage gfx/webrender_bindings/RenderThread.cpp:634
2 xul.dll mozilla::layers::BufferTextureHost::CreateRenderTexture gfx/layers/composite/TextureHost.cpp:604
3 xul.dll mozilla::webgpu::WebGPUParent::RecvDeviceCreateSwapChain dom/webgpu/ipc/WebGPUParent.cpp:560
4 xul.dll mozilla::webgpu::PWebGPUParent::OnMessageReceived ipc/ipdl/PWebGPUParent.cpp:2244
5 xul.dll mozilla::layers::PCompositorManagerParent::OnMessageReceived ipc/ipdl/PCompositorManagerParent.cpp:197
6 xul.dll mozilla::ipc::MessageChannel::DispatchMessage ipc/glue/MessageChannel.cpp:2111
7 xul.dll mozilla::ipc::MessageChannel::MessageTask::Run ipc/glue/MessageChannel.cpp:1990
8 xul.dll MessageLoop::DoWork ipc/chromium/src/base/message_loop.cc:523
9 xul.dll base::MessagePumpForUI::DoRunLoop ipc/chromium/src/base/message_pump_win.cc:203

There have been a few reports on Nightly starting with build id 20200408214238.

Severity: -- → normal
Flags: needinfo?(dmalyshau)
Priority: -- → P3
Assignee: nobody → dmalyshau
Status: NEW → ASSIGNED
Flags: needinfo?(dmalyshau)

Added a macOS-specific crash signature

Crash Signature: [@ RtlAcquireSRWLockExclusive | mozilla::wr::RenderThread::RegisterExternalImage] → [@ RtlAcquireSRWLockExclusive | mozilla::wr::RenderThread::RegisterExternalImage] [@ pthread_mutex_trylock]

Filed bug 1633473 to make the macOS signature more readable and less generic.

The severity field is not set for this bug.
:jbonisteel, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(jbonisteel)
Severity: normal → S3
Flags: needinfo?(jbonisteel)

Added the new macOS signature.

Crash Signature: [@ RtlAcquireSRWLockExclusive | mozilla::wr::RenderThread::RegisterExternalImage] [@ pthread_mutex_trylock] → [@ RtlAcquireSRWLockExclusive | mozilla::wr::RenderThread::RegisterExternalImage] [@ pthread_mutex_trylock] [@ __pthread_mutex_lock | mozilla::detail::MutexImpl::lock | mozilla::wr::RenderThread::RegisterExternalImage]

Actually that was the Linux one, this is the macOS one.

Crash Signature: [@ RtlAcquireSRWLockExclusive | mozilla::wr::RenderThread::RegisterExternalImage] [@ pthread_mutex_trylock] [@ __pthread_mutex_lock | mozilla::detail::MutexImpl::lock | mozilla::wr::RenderThread::RegisterExternalImage] → [@ RtlAcquireSRWLockExclusive | mozilla::wr::RenderThread::RegisterExternalImage] [@ pthread_mutex_trylock] [@ __pthread_mutex_lock | mozilla::detail::MutexImpl::lock | mozilla::wr::RenderThread::RegisterExternalImage] [@ pthread_mutex_trylock | mozill…

There's a useful comment with an STR:

URL:

https://codepen.io/alaingalvan/embed/GRgvLGw?height=480&theme-id=default&default-tab=result

Comment:

Opened a site with WebGPU examples.
Clicked to activate the example and the browser immediately crashed.

This is from a machine running Ubuntu 20.04, with a GeForce RTX 2060 graphics card running nVidia closed-source driver version 440.64.0.0.

From the looks of it what seems to be happening is that mRenderTextureMapLock is NULL and trying to lock it causes the crash.

It's odd because mRenderTextureMapLock is created on object creation and never explicitly deleted so it's unclear when it might become NULL... unless it's one of the internal components of the lock that has become NULL. Or maybe I'm just reading the crash wrong.

Closing because no crashes reported for 12 weeks.

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.