Closed Bug 1632172 Opened 4 months ago Closed 3 months ago

[wpt-sync] Sync PR 23169 - [@property] Initial should be required for non-universal syntax

Categories

(Core :: CSS Parsing and Computation, task, P4)

task

Tracking

()

RESOLVED FIXED
mozilla77
Tracking Status
firefox77 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 23169 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/23169
Details from upstream follow.

Anders Hartvoll Ruud <andruud@chromium.org> wrote:

[@property] Initial should be required for non-universal syntax

  • Require an initial value for the @property rule to be valid.
    (Except universal syntax definitions).
  • Rename IsTokenStream -> IsUniversal. (It's nice to have names that
    match the spec concepts).
  • Fix typo 'initalValue' in an otherwise unrelated test.

Bug: 973830
Change-Id: I675f0c46b7918e4a81287d600d977ff76484cf8b
Reviewed-on: https://chromium-review.googlesource.com/2160886
WPT-Export-Revision: e137582a2210abda4765df504f828b19431308f5

PR 23169 applied with additional changes from upstream: 8ab9b393636f35a1ddeb0526483b9c03013a4f98, 0a970f919e3a8f134f6b8b4cd03e63ef865bd38f
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 66 tests

Status Summary

Firefox

OK : 2
PASS: 11[GitHub] 75[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt]
FAIL: 58

Chrome

OK : 2
PASS: 11
FAIL: 58

Safari

OK : 2
PASS: 11
FAIL: 58

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-properties-values-api/at-property-animation.html
@keyframes picks up the latest @property in the document: FAIL (Chrome: FAIL, Safari: FAIL)
Ongoing animation picks up redeclared custom property: FAIL (Chrome: FAIL, Safari: FAIL)
Ongoing animation picks up redeclared intial value: FAIL (Chrome: FAIL, Safari: FAIL)
Ongoing animation picks up redeclared inherits flag: FAIL (Chrome: FAIL, Safari: FAIL)
Ongoing animation matches new keyframes against the current registration: FAIL (Chrome: FAIL, Safari: FAIL)
Ongoing animation picks up redeclared meaning of 'unset': FAIL (Chrome: FAIL, Safari: FAIL)
@keyframes works with @property: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-properties-values-api/at-property.html
Rule applied [<transform-list>, rotateX(0deg), false]: FAIL (Chrome: FAIL, Safari: FAIL)
Rule applied [<color>, rgb(1, 2, 3), false]: FAIL (Chrome: FAIL, Safari: FAIL)
Attribute 'inherits' returns expected value for ["false"]: FAIL (Chrome: FAIL, Safari: FAIL)
Rule applied [<number>, 2.5, false]: FAIL (Chrome: FAIL, Safari: FAIL)
Rule applied [<angle>, 42deg, false]: FAIL (Chrome: FAIL, Safari: FAIL)
Attribute 'inherits' returns expected value for [0]: FAIL (Chrome: FAIL, Safari: FAIL)
Rule applied [<angle>, 1turn, false]: FAIL (Chrome: FAIL, Safari: FAIL)
Rule applied [<length-percentage>, 10px, false]: FAIL (Chrome: FAIL, Safari: FAIL)
Rule applied [<length-percentage>, 10%, false]: FAIL (Chrome: FAIL, Safari: FAIL)
Attribute 'syntax' returns expected value for [rgb(255, 0, 0)]: FAIL (Chrome: FAIL, Safari: FAIL)
Rule applied [<integer>, 5, false]: FAIL (Chrome: FAIL, Safari: FAIL)
Attribute 'initial-value' returns expected value for [red]: FAIL (Chrome: FAIL, Safari: FAIL)
Attribute 'syntax' returns expected value for ["<color># | <image> | none"]: FAIL (Chrome: FAIL, Safari: FAIL)
Rule applied [, if(){}, false]: FAIL (Chrome: FAIL, Safari: FAIL)
Rule applied [<color>, green, false]: FAIL (Chrome: FAIL, Safari: FAIL)
Inherited properties inherit: FAIL (Chrome: FAIL, Safari: FAIL)
Attribute 'initial-value' returns expected value for [rgb(1, 2, 3)]: FAIL (Chrome: FAIL, Safari: FAIL)
Rule applied [<resolution>, 96dpi, false]: FAIL (Chrome: FAIL, Safari: FAIL)
Attribute 'inherits' returns expected value for [none]: FAIL (Chrome: FAIL, Safari: FAIL)
Non-inherited properties do not inherit: FAIL (Chrome: FAIL, Safari: FAIL)
Attribute 'inherits' returns expected value for ["true"]: FAIL (Chrome: FAIL, Safari: FAIL)
Rule applied [<color>, tomato, false]: FAIL (Chrome: FAIL, Safari: FAIL)
Rule applied [<time>, 10s, false]: FAIL (Chrome: FAIL, Safari: FAIL)
Rule applied [<length>, 10px, false]: FAIL (Chrome: FAIL, Safari: FAIL)
Attribute 'initial-value' returns expected value for [var(--x)]: FAIL (Chrome: FAIL, Safari: FAIL)
Rule applied [<transform-list>, rotateX(0deg) translateX(10px), false]: FAIL (Chrome: FAIL, Safari: FAIL)
Rule applied [<length-percentage>, calc(10% + 10px), false]: FAIL (Chrome: FAIL, Safari: FAIL)
Attribute 'syntax' returns expected value for ["notasyntax"]: FAIL (Chrome: FAIL, Safari: FAIL)
Rule applied [<time>, 1000ms, false]: FAIL (Chrome: FAIL, Safari: FAIL)
Attribute 'syntax' returns expected value for ["foo | bar | baz"]: FAIL (Chrome: FAIL, Safari: FAIL)
Attribute 'initial-value' returns expected value for [if(){}]: FAIL (Chrome: FAIL, Safari: FAIL)
Attribute 'syntax' returns expected value for [foo | bar]: FAIL (Chrome: FAIL, Safari: FAIL)
Attribute 'inherits' returns expected value for [1]: FAIL (Chrome: FAIL, Safari: FAIL)
Rule applied [<image>, url("http://a/"), false]: FAIL (Chrome: FAIL, Safari: FAIL)
Attribute 'initial-value' returns expected value for [10px]: FAIL (Chrome: FAIL, Safari: FAIL)
Attribute 'inherits' returns expected value for [true]: FAIL (Chrome: FAIL, Safari: FAIL)
Attribute 'syntax' returns expected value for ["
"]: FAIL (Chrome: FAIL, Safari: FAIL)
Attribute 'syntax' returns expected value for ["<color>"]: FAIL (Chrome: FAIL, Safari: FAIL)
Attribute 'initial-value' returns expected value for [foo]: FAIL (Chrome: FAIL, Safari: FAIL)
Attribute 'syntax' returns expected value for [red]: FAIL (Chrome: FAIL, Safari: FAIL)
Attribute 'syntax' returns expected value for [<color>]: FAIL (Chrome: FAIL, Safari: FAIL)
Rule applied [<percentage>, 10%, false]: FAIL (Chrome: FAIL, Safari: FAIL)
Rule applied [<url>, url("http://a/"), false]: FAIL (Chrome: FAIL, Safari: FAIL)
Initial value may be omitted for universal registration: FAIL (Chrome: FAIL, Safari: FAIL)
Rule applied [<color>, tomato, true]: FAIL (Chrome: FAIL, Safari: FAIL)
Attribute 'syntax' returns expected value for ["<color> | none"]: FAIL (Chrome: FAIL, Safari: FAIL)
Rule applied [<resolution>, 50dppx, false]: FAIL (Chrome: FAIL, Safari: FAIL)
Initial values substituted as computed value: FAIL (Chrome: FAIL, Safari: FAIL)
Attribute 'inherits' returns expected value for [calc(0)]: FAIL (Chrome: FAIL, Safari: FAIL)
Attribute 'inherits' returns expected value for [false]: FAIL (Chrome: FAIL, Safari: FAIL)
Rule applied [<transform-function>, rotateX(0deg), false]: FAIL (Chrome: FAIL, Safari: FAIL)

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 66 tests

Status Summary

Firefox

OK : 2
PASS: 11[GitHub] 75[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt]
FAIL: 58

Chrome

OK : 2
PASS: 11
FAIL: 58

Safari

OK : 2
PASS: 11
FAIL: 58

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-properties-values-api/at-property-animation.html
@keyframes picks up the latest @property in the document: FAIL (Chrome: FAIL, Safari: FAIL)
Ongoing animation picks up redeclared custom property: FAIL (Chrome: FAIL, Safari: FAIL)
Ongoing animation picks up redeclared intial value: FAIL (Chrome: FAIL, Safari: FAIL)
Ongoing animation picks up redeclared inherits flag: FAIL (Chrome: FAIL, Safari: FAIL)
Ongoing animation matches new keyframes against the current registration: FAIL (Chrome: FAIL, Safari: FAIL)
Ongoing animation picks up redeclared meaning of 'unset': FAIL (Chrome: FAIL, Safari: FAIL)
@keyframes works with @property: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-properties-values-api/at-property.html
Rule applied [<transform-list>, rotateX(0deg), false]: FAIL (Chrome: FAIL, Safari: FAIL)
Rule applied [<color>, rgb(1, 2, 3), false]: FAIL (Chrome: FAIL, Safari: FAIL)
Attribute 'inherits' returns expected value for ["false"]: FAIL (Chrome: FAIL, Safari: FAIL)
Rule applied [<number>, 2.5, false]: FAIL (Chrome: FAIL, Safari: FAIL)
Rule applied [<angle>, 42deg, false]: FAIL (Chrome: FAIL, Safari: FAIL)
Attribute 'inherits' returns expected value for [0]: FAIL (Chrome: FAIL, Safari: FAIL)
Rule applied [<angle>, 1turn, false]: FAIL (Chrome: FAIL, Safari: FAIL)
Rule applied [<length-percentage>, 10px, false]: FAIL (Chrome: FAIL, Safari: FAIL)
Rule applied [<length-percentage>, 10%, false]: FAIL (Chrome: FAIL, Safari: FAIL)
Attribute 'syntax' returns expected value for [rgb(255, 0, 0)]: FAIL (Chrome: FAIL, Safari: FAIL)
Rule applied [<integer>, 5, false]: FAIL (Chrome: FAIL, Safari: FAIL)
Attribute 'initial-value' returns expected value for [red]: FAIL (Chrome: FAIL, Safari: FAIL)
Attribute 'syntax' returns expected value for ["<color># | <image> | none"]: FAIL (Chrome: FAIL, Safari: FAIL)
Rule applied [, if(){}, false]: FAIL (Chrome: FAIL, Safari: FAIL)
Rule applied [<color>, green, false]: FAIL (Chrome: FAIL, Safari: FAIL)
Inherited properties inherit: FAIL (Chrome: FAIL, Safari: FAIL)
Attribute 'initial-value' returns expected value for [rgb(1, 2, 3)]: FAIL (Chrome: FAIL, Safari: FAIL)
Rule applied [<resolution>, 96dpi, false]: FAIL (Chrome: FAIL, Safari: FAIL)
Attribute 'inherits' returns expected value for [none]: FAIL (Chrome: FAIL, Safari: FAIL)
Non-inherited properties do not inherit: FAIL (Chrome: FAIL, Safari: FAIL)
Attribute 'inherits' returns expected value for ["true"]: FAIL (Chrome: FAIL, Safari: FAIL)
Rule applied [<color>, tomato, false]: FAIL (Chrome: FAIL, Safari: FAIL)
Rule applied [<time>, 10s, false]: FAIL (Chrome: FAIL, Safari: FAIL)
Rule applied [<length>, 10px, false]: FAIL (Chrome: FAIL, Safari: FAIL)
Attribute 'initial-value' returns expected value for [var(--x)]: FAIL (Chrome: FAIL, Safari: FAIL)
Rule applied [<transform-list>, rotateX(0deg) translateX(10px), false]: FAIL (Chrome: FAIL, Safari: FAIL)
Rule applied [<length-percentage>, calc(10% + 10px), false]: FAIL (Chrome: FAIL, Safari: FAIL)
Attribute 'syntax' returns expected value for ["notasyntax"]: FAIL (Chrome: FAIL, Safari: FAIL)
Rule applied [<time>, 1000ms, false]: FAIL (Chrome: FAIL, Safari: FAIL)
Attribute 'syntax' returns expected value for ["foo | bar | baz"]: FAIL (Chrome: FAIL, Safari: FAIL)
Attribute 'initial-value' returns expected value for [if(){}]: FAIL (Chrome: FAIL, Safari: FAIL)
Attribute 'syntax' returns expected value for [foo | bar]: FAIL (Chrome: FAIL, Safari: FAIL)
Attribute 'inherits' returns expected value for [1]: FAIL (Chrome: FAIL, Safari: FAIL)
Rule applied [<image>, url("http://a/"), false]: FAIL (Chrome: FAIL, Safari: FAIL)
Attribute 'initial-value' returns expected value for [10px]: FAIL (Chrome: FAIL, Safari: FAIL)
Attribute 'inherits' returns expected value for [true]: FAIL (Chrome: FAIL, Safari: FAIL)
Attribute 'syntax' returns expected value for ["
"]: FAIL (Chrome: FAIL, Safari: FAIL)
Attribute 'syntax' returns expected value for ["<color>"]: FAIL (Chrome: FAIL, Safari: FAIL)
Attribute 'initial-value' returns expected value for [foo]: FAIL (Chrome: FAIL, Safari: FAIL)
Attribute 'syntax' returns expected value for [red]: FAIL (Chrome: FAIL, Safari: FAIL)
Attribute 'syntax' returns expected value for [<color>]: FAIL (Chrome: FAIL, Safari: FAIL)
Rule applied [<percentage>, 10%, false]: FAIL (Chrome: FAIL, Safari: FAIL)
Rule applied [<url>, url("http://a/"), false]: FAIL (Chrome: FAIL, Safari: FAIL)
Initial value may be omitted for universal registration: FAIL (Chrome: FAIL, Safari: FAIL)
Rule applied [<color>, tomato, true]: FAIL (Chrome: FAIL, Safari: FAIL)
Attribute 'syntax' returns expected value for ["<color> | none"]: FAIL (Chrome: FAIL, Safari: FAIL)
Rule applied [<resolution>, 50dppx, false]: FAIL (Chrome: FAIL, Safari: FAIL)
Initial values substituted as computed value: FAIL (Chrome: FAIL, Safari: FAIL)
Attribute 'inherits' returns expected value for [calc(0)]: FAIL (Chrome: FAIL, Safari: FAIL)
Attribute 'inherits' returns expected value for [false]: FAIL (Chrome: FAIL, Safari: FAIL)
Rule applied [<transform-function>, rotateX(0deg), false]: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8236f2312205
[wpt PR 23169] - [@property] Initial should be required for non-universal syntax, a=testonly
https://hg.mozilla.org/integration/autoland/rev/f640897b7f64
[wpt PR 23169] - Update wpt metadata, a=testonly
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/7fe7d0cc8de4
[wpt PR 23169] - [@property] Initial should be required for non-universal syntax, a=testonly
https://hg.mozilla.org/integration/autoland/rev/2ff1de7ecca0
[wpt PR 23169] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
You need to log in before you can comment on or make changes to this bug.