1632199 - PopupNotification doorhangers can overlay tab prompts

Status: RESOLVED FIXED

(Firefox :: Security, defect, P1)

Description

[Emma Zühlcke [:emz]]

Attachment: addon-doorhanger-covers-tabprompt.png

There can be situations where user input is expected on a tab prompt, but a doorhanger covers it up.
An example for this is installing an addon from a site that requires http auth. Here is a testcase that shows this behavior.

Comment 1

[Johann Hofmann [:johannh]]

Hmm off-hand that feels like a blocker for shipping those prompts to me, what do you think?

Comment 2

[Emma Zühlcke [:emz]]

Attachment: Bug 1632199 - Suppress PopupNotifications while tab system prompts are shown. r=johannh!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1e23efe620eb
Suppress PopupNotifications while tab system prompts are shown. r=johannh

Comment 4

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/1e23efe620eb

Comment 5

[Timea Cernea [:tbabos][inactive]]

Hey Paul, could you please share that site with the http auth and addon install separately so I can verify it manually?

Comment 6

[Emma Zühlcke [:emz]]

We only have the testcase I linked above. I can build a simple test page for manual verification.

Comment 7

[Emma Zühlcke [:emz]]

A simple way to test this:

1. Go to https://permission.site
2. Click on "Location", a permission doorhanger should appear
3. Enter [e-mail] in the url bar and press return. A tab prompt should appear, the doorhanger should be hidden and should not cover up the the tab prompt.
4. In the prompt, click "no", the permission doorhanger should appear again.