1694811 - Restart panel conflicts with Close Tabs Confirmation modal (notification shows up but is unclickable)

Status: RESOLVED FIXED

(Firefox :: General, defect, P1)

Description

[katieC]

Attachment: Screenshot_Modal_Panel_Feb24.png

In Nightly, the restart to update panel (hamburger menu notification / see attached screenshot) conflicts visually with the close tab confirmation modal. Restart panel buttons were not clickable.

Comment 1

[:Gijs (he/him)]

We should suppress these notifications when the modal shows, and re-show them when the modal goes away.

Comment 2

[:Gijs (he/him)]

Update priority to reflect proton priorities.

Comment 3

[Emma Zühlcke [:emz]]

Bug 1632199 was a similar issue for tab-level dialogs. PopupNotifications can be suppressed by adding a condition to this callback: https://searchfox.org/mozilla-central/rev/5a66c4b4a41ab78a87c30c9db0d93c732c534402/browser/base/content/browser.js#439-447

Comment 4

[Romain Testard [:RT]]

Marking as P1. Per experience review we agreed to mark as P1 bug the ones that will block MR1.

Comment 5

[Alex Thayer [:alexical] (she/her)]

Attachment: Bug 1694811 - Extend existing popup hiding logic to PanelUI r?Gijs

This effectively mirrors the panel hiding logic we use to hide
PopupNotifications panels so that we also hide notifications attached to the
hamburger menu. This will cover alerts and other similar modals originating
from content.

Comment 6

[Alex Thayer [:alexical] (she/her)]

Attachment: Bug 1694811 - Hide notifications for gDialogBox modals r?Gijs

Fairly self-explanatory. This just extends the tab-based modal popup hiding
behavior to modals going through gDialogBox.

Depends on D109526

Comment 7

[Alex Thayer [:alexical] (she/her)]

Attachment: Bug 1694811 - Ensure tabmodalprompts also hide PanelUI notification panels r?Gijs

Depends on D109527

Comment 8

[Alex Thayer [:alexical] (she/her)]

Attachment: Bug 1694811 - Add test for modal/panelUI interactions r?Gijs

Depends on D109528

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b30fef8108f2
Extend existing popup hiding logic to PanelUI r=Gijs
https://hg.mozilla.org/integration/autoland/rev/d3ad3e22d8ec
Hide notifications for gDialogBox modals r=Gijs
https://hg.mozilla.org/integration/autoland/rev/3871c381f016
Ensure tabmodalprompts also hide PanelUI notification panels r=Gijs
https://hg.mozilla.org/integration/autoland/rev/c20ac9c5a297
Add test for modal/panelUI interactions r=Gijs

Comment 10

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/b30fef8108f2
https://hg.mozilla.org/mozilla-central/rev/d3ad3e22d8ec
https://hg.mozilla.org/mozilla-central/rev/3871c381f016
https://hg.mozilla.org/mozilla-central/rev/c20ac9c5a297

Comment 11

[Daniel Holbert [:dholbert]]

Late-breaking note here: there's one other sort of popup that seems to suffer from the same issue as described here, which might want a similar fix. See bug 1880685.