1632229 - Use consistent script flags for BinAST lazy scripts

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Description

[Ted Campbell [:tcampbell]]

There are a few issues in the BinAST frontend not being patched as changes to the normal parser were made. These patches fix some of them.

Comment 1

[Ted Campbell [:tcampbell]]

Attachment: Bug 1632229 - Use BaseScript::CreateRawLazy in the BinAST case. r?mgaudet

Lazy scripts generated by BinAST parser do not track their inner-functions or
their closed-over-binding info so remove misleading code. In the
finishLazyFunction code the pc_ is actually for parent and it is invalid
for us to use it here.

Comment 2

[Ted Campbell [:tcampbell]]

Attachment: Bug 1632229 - Fixup BinAST lazy script flag computation. r?mgaudet

This fixes some issues that snuck in for flag initialization in the BinAST
frontend. These changes match LazyScriptCreationData::create behaviour now.

Also remove a redundant strict flag initialization from BCEScriptStencil that
was missed in Bug 1628111.

Depends on D72008

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/136080eee01b
Use BaseScript::CreateRawLazy in the BinAST case. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/acd35b5038b9
Fixup BinAST lazy script flag computation. r=mgaudet

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/136080eee01b
https://hg.mozilla.org/mozilla-central/rev/acd35b5038b9