Closed Bug 1632229 Opened 4 months ago Closed 4 months ago

Use consistent script flags for BinAST lazy scripts

Categories

(Core :: JavaScript Engine, task, P1)

task

Tracking

()

RESOLVED FIXED
mozilla77
Tracking Status
firefox77 --- fixed

People

(Reporter: tcampbell, Assigned: tcampbell)

References

Details

Attachments

(2 files)

There are a few issues in the BinAST frontend not being patched as changes to the normal parser were made. These patches fix some of them.

Lazy scripts generated by BinAST parser do not track their inner-functions or
their closed-over-binding info so remove misleading code. In the
finishLazyFunction code the pc_ is actually for parent and it is invalid
for us to use it here.

This fixes some issues that snuck in for flag initialization in the BinAST
frontend. These changes match LazyScriptCreationData::create behaviour now.

Also remove a redundant strict flag initialization from BCEScriptStencil that
was missed in Bug 1628111.

Depends on D72008

Pushed by tcampbell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/136080eee01b
Use BaseScript::CreateRawLazy in the BinAST case. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/acd35b5038b9
Fixup BinAST lazy script flag computation. r=mgaudet
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla77
You need to log in before you can comment on or make changes to this bug.