1632258 - [wpt-sync] Sync PR 23181 - Adds slotchange event for Imperative Slot API.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 23181 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/23181
Details from upstream follow.

Yu Han <[e-mail]> wrote:

Adds slotchange event for Imperative Slot API.

Prior to this CL slotchange event is not fired when calling the
Imperative Slot API.

This CL adds the ability to fire slotchange event for Imperative Slot
API. It does so by detecting candidates nodes changed during the
call and fires slotchange event if changed. This CL only implements the
assign() function's portion of the slotchange event. In the next CL,
I will implement slotchange event for removing nodes and slots.

Bug:869308
Change-Id: I13851d1788fc6cf8b0ea109fb136a2f029e61e70

Reviewed-on: https://chromium-review.googlesource.com/2161369
WPT-Export-Revision: efd0cbff9409da3bd51eb1d8cf03076861a51e64

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=c1bfea8f421a28f8130edc8cdf7d886519fd161e

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Safari on GitHub CI

Total 68 tests

Status Summary

Firefox

OK : 1
PASS: 67
FAIL: 7

Safari

OK : 1
FAIL: 7

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/shadow-dom/slots-imperative-api-slotchange.tentative.html
slotchange event must not fire synchronously.: FAIL (Safari: FAIL)
Fire slotchange event when order of assigned nodes changes.: FAIL (Safari: FAIL)
slotchange event should not fire when assignments do not change assignedNodes.: FAIL (Safari: FAIL)
Fire slotchange event when slot's assigned nodes changes.: FAIL (Safari: FAIL)
Fire slotchange event on previous slot and new slot when node is reassigned.: FAIL (Safari: FAIL)
slotchange event should not fire when same node is assigned.: FAIL (Safari: FAIL)
Fire slotchange event on node assignment and when assigned node is removed.: FAIL (Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/68ed94156f5e
[wpt PR 23181] - Adds slotchange event for Imperative Slot API., a=testonly
https://hg.mozilla.org/integration/autoland/rev/d5ab266f6e49
[wpt PR 23181] - Update wpt metadata, a=testonly

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cf4b06c05ed3
[wpt PR 23181] - Adds slotchange event for Imperative Slot API., a=testonly
https://hg.mozilla.org/integration/autoland/rev/ce8be6807244
[wpt PR 23181] - Update wpt metadata, a=testonly

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/cf4b06c05ed3
https://hg.mozilla.org/mozilla-central/rev/ce8be6807244