1632273 - Update ImmutableScriptFlags flag comments

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Description

[Ted Campbell [:tcampbell]]

The comments need some more cleanup as we are getting closer to done our changes there.

Comment 1

[Ted Campbell [:tcampbell]]

Attachment: Bug 1632273 - Reorder {Immutable,Mutable}ScriptFlags flags. r?jorendorff!

Reorder and renumber the flags. All flag comments are entirely unchanged.
Follow-up patches will update those comments.

Comment 2

[Ted Campbell [:tcampbell]]

Attachment: Bug 1632273 - Update ImmutableScriptFlags docs (Input). r?jandem!,jorendorff!

Update flag comments for "input" flags. These flags are not determined by the
source text generally come from CompileOptions instead. They are preserved on
scripts and stencils to know if bytecode can be reused.

Depends on D72164

Comment 3

[Ted Campbell [:tcampbell]]

Attachment: Bug 1632273 - Update ImmutableScriptFlags docs (Parse). r?jorendorff!

These flags are derived by the parser and are set for all scripts
(top-level/function, lazy/non-lazy).

Depends on D72165

Comment 4

[Ted Campbell [:tcampbell]]

Attachment: Bug 1632273 - Update ImmutableScriptFlags docs (Function). r?jorendorff!

These flags are derived by the parser but are only defined for functions.

Depends on D72166

Comment 5

[Ted Campbell [:tcampbell]]

Attachment: Bug 1632273 - Update MutableScriptFlags docs. r?jandem!

Depends on D72167

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a2173b0343d5
Reorder {Immutable,Mutable}ScriptFlags flags. r=jorendorff
https://hg.mozilla.org/integration/autoland/rev/683f2f34cf6a
Update ImmutableScriptFlags docs (Input). r=jandem,jorendorff
https://hg.mozilla.org/integration/autoland/rev/f952b59a59c3
Update ImmutableScriptFlags docs (Parse). r=jorendorff
https://hg.mozilla.org/integration/autoland/rev/071e17eed06e
Update ImmutableScriptFlags docs (Function). r=jorendorff
https://hg.mozilla.org/integration/autoland/rev/40f5ad8a9e96
Update MutableScriptFlags docs. r=jandem,jorendorff

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/a2173b0343d5
https://hg.mozilla.org/mozilla-central/rev/683f2f34cf6a
https://hg.mozilla.org/mozilla-central/rev/f952b59a59c3
https://hg.mozilla.org/mozilla-central/rev/071e17eed06e
https://hg.mozilla.org/mozilla-central/rev/40f5ad8a9e96