1632343 - --enable-openpgp is incompatible with --enable-artifact-builds

Status: RESOLVED FIXED

(MailNews Core :: Security: OpenPGP, defect)

Description

[Geoff Lankow (:darktrojan)]

The OpenPGP configure checks require a compiler. Artifact builds require not having a compiler. This isn't going to work.

For now, this can be worked around with --disable-openpgp, so probably what needs to happen is a check that we're not in an artifact build before including openpgp.configure.

Comment 1

[Rob Lemley [:rjl]]

Attachment: Fix artifact builds when --enable-openpgp is set

I ran artifact and regular Linux64 builds locally (clobbered).

Comment 2

[Geoff Lankow (:darktrojan)]

Comment on attachment 9142606 [details] [diff] [review]
Fix artifact builds when --enable-openpgp is set

Assuming it's just white space causing most of the change, this is fine.

Comment 3

[Rob Lemley [:rjl]]

Yeah Python indenting for the most part.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d010d86cedeb
Fix artifact builds when --enable-openpgp is set. r=darktrojan DONTBUILD

Comment 5

[Rob Lemley [:rjl]]

Attachment: Follow-up: Fix l10n repacks on Daily build

COMPILE_ENVIRONMENT will not be set for L10n repacks or artifact
builds.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/53c02cf46815
Follow-up: Fix l10n repacks on Daily build. r=mkmelin rs=bustage-fix DONTBUILD