163299 - Can't change cc accessible checkbox

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Bradley Baetz (:bbaetz)]

I stuffed up the fielddefs fieldname for bug 161865. Patch coming

Comment 1

[Bradley Baetz (:bbaetz)]

Attachment: oops

Comment 2

[Bradley Baetz (:bbaetz)]

Who wants to review this?

Comment 3

[J. Paul Reed [:preed]]

Comment on attachment 95733 [details] [diff] [review]
oops

"oops."

r=preed

Comment 4

[Joel Peshkin]

Comment on attachment 95733 [details] [diff] [review]
oops

2xr from Joel assuming that bbaetz saw this fix the original problem. 
It's clear that this is the right thing to do.

Comment 5

[Gervase Markham [:gerv]]

Sorry I didn't get here sooner. Hmm. How annoying. It's stuff like this that
makes checksetup.pl 3221 lines long. :-|

It's only been like this for a week. Can we leave the fixup hack in for a month
and then remove it, on the basis that if someone updated this week, that are
likely to be a developer, and will update again in the next month?

Gerv

Comment 6

[Bradley Baetz (:bbaetz)]

gerv: I dunno - see what developers@ thinks? HAving it there won't harm
anything; it just shows up on the query checkbox, then.

Checked in, but leaving open to possibly remove the hack later.

Comment 7

[Bradley Baetz (:bbaetz)]

OK, this got checked in ages ago. Lets keep the line in - its not doing any harm.