1633010 - Simplify the responsibility of media controller

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, task, P1)

Description

[Alastor Wu [:alwu]]

Media controller is having too much responsibility, we should remove the responsibilities of handling playback related status to other delegates so that media controller can focus on high level concept of controlling media.

Comment 1

[Alastor Wu [:alwu]]

Attachment: Bug 1633010 - part1 : send context Id as a parameter when updating media playback and audible state.

Comment 2

[Alastor Wu [:alwu]]

Attachment: Bug 1633010 - part2 : use composition for media session controller.

Comment 3

[Alastor Wu [:alwu]]

Attachment: Bug 1633010 - part3 : use a delegate to handle the tasks of determining playback related status.

Comment 4

[Alastor Wu [:alwu]]

Attachment: Bug 1633010 - part5 : move declared and guessed playback state into MediaSessionControllerImpl.

Comment 5

[Alastor Wu [:alwu]]

Attachment: Bug 1633010 - part4 : use only one delegate in the media controller.

Comment 6

[Alastor Wu [:alwu]]

After discuss with Bryce offline, I'm going to recheck the design and will ask for a review later.

Comment 7

[Alastor Wu [:alwu]]

Attachment: Bug 1633010 - part2 : create `MediaPlaybackStatus` to handle the tasks of determining playback related status.

Comment 8

[Alastor Wu [:alwu]]

Attachment: Bug 1633010 - part3 : move MediaPlaybackStatus to MediaSessionController.

Comment 9

[Alastor Wu [:alwu]]

Attachment: Bug 1633010 - part4 : move declared and guessed playback state into `MediaSessionController`.

Comment 10

[Alastor Wu [:alwu]]

Attachment: Bug 1633010 - part5 : extend `IMediaInfoUpdater`.

Comment 11

[Alastor Wu [:alwu]]

Attachment: Bug 1633010 - part6 : use `IMediaController` if we only want to access control related methods

Comment 12

[Alastor Wu [:alwu]]

Attachment: Bug 1633010 - part7 : rename variables and remove unnecessary spaces

Comment 13

[Alastor Wu [:alwu]]

Attachment: Bug 1633010 - part8 : rename `MediaSessionController` to `MediaStatusManager`

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b581af0ca6ea
part1 : send context Id as a parameter when updating media playback and audible state. r=bryce,chunmin
https://hg.mozilla.org/integration/autoland/rev/00c095ba852d
part2 : create `MediaPlaybackStatus` to handle the tasks of determining playback related status. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/12e357923acf
part3 : move MediaPlaybackStatus to MediaSessionController. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/570cdab31d42
part4 : move declared and guessed playback state into `MediaSessionController`. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/3f1356460936
part5 : extend `IMediaInfoUpdater`. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/b32d1b16ace5
part6 : use `IMediaController` if we only want to access control related methods r=chunmin
https://hg.mozilla.org/integration/autoland/rev/7b844490b8fe
part7 : rename variables and remove unnecessary spaces r=chunmin
https://hg.mozilla.org/integration/autoland/rev/5b6d8d1bd950
part8 : rename `MediaSessionController` to `MediaStatusManager` r=chunmin

Comment 15

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/b581af0ca6ea
https://hg.mozilla.org/mozilla-central/rev/00c095ba852d
https://hg.mozilla.org/mozilla-central/rev/12e357923acf
https://hg.mozilla.org/mozilla-central/rev/570cdab31d42
https://hg.mozilla.org/mozilla-central/rev/3f1356460936
https://hg.mozilla.org/mozilla-central/rev/b32d1b16ace5
https://hg.mozilla.org/mozilla-central/rev/7b844490b8fe
https://hg.mozilla.org/mozilla-central/rev/5b6d8d1bd950