1633145 - Some JSAPI cleanup

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Comment 1

[Tom S [:evilpie]]

Attachment: Bug 1633145 - Hide internal flags in JSPropertySpec. r?arai

Consumers should not have to care about JSPROP_INTERNAL_USE_BIT.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d83b3a48d20b
Hide internal flags in JSPropertySpec. r=arai

Comment 3

[Tom S [:evilpie]]

Attachment: Bug 1633145 - Add more methods to JS::PropertyKey. r?arai

Comment 4

[Tom S [:evilpie]]

Attachment: Bug 1633145 - Add PropertyKey::isWellKnownSymbol. r?arai

Depends on D72536

Comment 5

[Tom S [:evilpie]]

Attachment: Bug 1633145 - Replace JSID_IS_GCTHING. r?arai

Depends on D72537

Comment 6

[Tom S [:evilpie]]

Attachment: Bug 1633145 - Add JS::PropertyKey::toGCCellPtr. r?sfink

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/d83b3a48d20b

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c3ad2fb081ba
Add more methods to JS::PropertyKey. r=arai
https://hg.mozilla.org/integration/autoland/rev/aa83cc21ce8c
Add PropertyKey::isWellKnownSymbol. r=arai
https://hg.mozilla.org/integration/autoland/rev/cc5d1f4ad5d9
Replace JSID_IS_GCTHING. r=arai
https://hg.mozilla.org/integration/autoland/rev/404e9ae4d35f
Add JS::PropertyKey::toGCCellPtr. r=arai

Comment 9

[Tom S [:evilpie]]

Attachment: Bug 1633145 - Replace INTERNED_STRING_TO_JSID. r?jandem

I am honstely still not convinced that this function should actually exists.
It seems like a convulted way of saying AtomToId, while also asserting that the atom is pinned.

Comment 10

[Tom S [:evilpie]]

Attachment: Bug 1633145 - Replace NON_INTEGER_ATOM_TO_JSID. r?jandem

This also allows us to remove JSID_FROM_BITS and gives us stronger assertions everywhere for the whack integer-string case.

Depends on D72563

Comment 11

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/c3ad2fb081ba
https://hg.mozilla.org/mozilla-central/rev/aa83cc21ce8c
https://hg.mozilla.org/mozilla-central/rev/cc5d1f4ad5d9
https://hg.mozilla.org/mozilla-central/rev/404e9ae4d35f

Comment 12

[Tom S [:evilpie]]

I didn't actually plan to get this much done here... I am going to file a bug to remove the rest of the old JSID API.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a67f17092a5b
Replace INTERNED_STRING_TO_JSID. r=jandem
https://hg.mozilla.org/integration/autoland/rev/bc9396fd6328
Replace NON_INTEGER_ATOM_TO_JSID. r=jandem

Comment 14

[Tom S [:evilpie]]

Attachment: Bug 1633145 - Bustage fix for jsglue.cpp

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c4212964f75
Bustage fix for jsglue.cpp

Comment 16

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/a67f17092a5b
https://hg.mozilla.org/mozilla-central/rev/bc9396fd6328
https://hg.mozilla.org/mozilla-central/rev/5c4212964f75