Closed Bug 1633145 Opened 1 month ago Closed 26 days ago

Some JSAPI cleanup

Categories

(Core :: JavaScript Engine, task, P3)

task

Tracking

()

RESOLVED FIXED
mozilla77
Tracking Status
firefox77 --- fixed

People

(Reporter: evilpie, Assigned: evilpie)

References

(Blocks 1 open bug)

Details

Attachments

(8 files)

No description provided.

Consumers should not have to care about JSPROP_INTERNAL_USE_BIT.

Pushed by evilpies@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/d83b3a48d20b
Hide internal flags in JSPropertySpec. r=arai
Regressions: 1633174
Depends on: 1320105

Depends on D72537

Pushed by evilpies@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/c3ad2fb081ba
Add more methods to JS::PropertyKey. r=arai
https://hg.mozilla.org/integration/autoland/rev/aa83cc21ce8c
Add PropertyKey::isWellKnownSymbol. r=arai
https://hg.mozilla.org/integration/autoland/rev/cc5d1f4ad5d9
Replace JSID_IS_GCTHING. r=arai
https://hg.mozilla.org/integration/autoland/rev/404e9ae4d35f
Add JS::PropertyKey::toGCCellPtr. r=arai

I am honstely still not convinced that this function should actually exists.
It seems like a convulted way of saying AtomToId, while also asserting that the atom is pinned.

This also allows us to remove JSID_FROM_BITS and gives us stronger assertions everywhere for the whack integer-string case.

Depends on D72563

Priority: -- → P3

I didn't actually plan to get this much done here... I am going to file a bug to remove the rest of the old JSID API.

Keywords: leave-open
Blocks: 1633829
Pushed by evilpies@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/a67f17092a5b
Replace INTERNED_STRING_TO_JSID. r=jandem
https://hg.mozilla.org/integration/autoland/rev/bc9396fd6328
Replace NON_INTEGER_ATOM_TO_JSID. r=jandem
You need to log in before you can comment on or make changes to this bug.