1633829 - Remove remaining uses of JSID methods

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Tom S. (please needinfo tschuster)]

In bug 1633145 I extended PropertyKey with methods like isString() etc. For example we should remove JSID_IS_STRING and replace it with isString.

Comment 1

[Nicolas B. Pierron [:nbp]]

Attachment: Bug 1633829 - Remove last reference to JSID_IS_STRING.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b791b4d37f17
Remove last reference to JSID_IS_STRING. r=evilpie

Comment 3

[Cristina Horotan [:chorotan]]

Backed out changeset b791b4d37f17 (Bug 1633829) for causing SM failures at RootingAPI.h

Backout: https://hg.mozilla.org/integration/autoland/rev/0278b86272728b17ade153f25ef5ec4442158066

Failure push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=daxQgnXLSpOvNhX3chgedQ.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=b791b4d37f17159d7ea14fe3be14dab2649308c2

Failure logs:
https://treeherder.mozilla.org/logviewer?job_id=423273312&repo=autoland&lineNumber=3786
https://treeherder.mozilla.org/logviewer?job_id=423277493&repo=autoland&lineNumber=3650

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0aa0e5c2b4b4
Remove last reference to JSID_IS_STRING. r=evilpie

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/0aa0e5c2b4b4