1633216 - [MIPS] Make spidermonkey builds compile

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect, P5)

Description

[Ted Campbell [:tcampbell]]

Fix some missing masm issues so that the simulator builds compile again.

Known Issues:

• WASM stack-maps aren't implemented so asm.js/wasm asserts out
• BaselineInterpreter makes unaligned accesses. I locally disabled the checks to get tests mostly passing.

Comment 1

[Ted Campbell [:tcampbell]]

Attachment: Bug 1633216 - Fix includes for MIPS simulators. r?iain

Comment 2

[Ted Campbell [:tcampbell]]

Attachment: Bug 1633216 - [mips32] Add missing MacroAssembler definitions. r?iain

Fix regressions so that mips32 simulator builds compile again.

Depends on D72545

Comment 3

[Ted Campbell [:tcampbell]]

Attachment: Bug 1633216 - [mips32] Use the extractTag return value. r?iain

Depends on D72546

Comment 4

[Ted Campbell [:tcampbell]]

Attachment: Bug 1633216 - [mips64] Fix MacroAssembler warnings. r?iain

Depends on D72547

Comment 5

[Ted Campbell [:tcampbell]]

There are also existing issues with a few BigInt JIT tests failing.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/df6e00a35e06
Fix includes for MIPS simulators. r=iain
https://hg.mozilla.org/integration/autoland/rev/3e57d802ddc1
[mips32] Add missing MacroAssembler definitions. r=iain
https://hg.mozilla.org/integration/autoland/rev/cf32c716650d
[mips32] Use the extractTag return value. r=iain
https://hg.mozilla.org/integration/autoland/rev/47138ff4dfc6
[mips64] Fix MacroAssembler warnings. r=iain

Comment 7

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/df6e00a35e06
https://hg.mozilla.org/mozilla-central/rev/3e57d802ddc1
https://hg.mozilla.org/mozilla-central/rev/cf32c716650d
https://hg.mozilla.org/mozilla-central/rev/47138ff4dfc6