1633338 - Investigate if we can use IsPotentiallyTrustworthy to indicate mIsSecure in BrowsingContext

Status: RESOLVED WONTFIX

(Core :: DOM: Security, task, P2)

Description

[Christoph Kerschbaumer [:ckerschb]]

As a follow up to Bug 1575356 we can investigate if we can rely on IsPotentiallyTrustworthy within Document::SetDocumentURI when we set isSecure on the browsingcontext.

Comment 1

[Chris Peterson [:cpeterson]]

Tracking for Fission Nightly milestone (M6)

Comment 2

[Christoph Kerschbaumer [:ckerschb]]

Attachment: Bug 1633338: Use IsPotentiallyTrustworthy to indicate top level window is secure for mixed content blocker. r=baku

Comment 3

[Christoph Kerschbaumer [:ckerschb]]

Seems we can:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=85b3a67494df9dd7155c694f865b4b9c8ff54e0a

Comment 4

[Christoph Kerschbaumer [:ckerschb]]

The change here got r+ed but is probably too risky to land that close to the end of the cycle. I'll land once we are in the new cycle.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d9608e8bff0c
Use IsPotentiallyTrustworthy to indicate top level window is secure for mixed content blocker. r=baku

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/d9608e8bff0c

Comment 7

[Christoph Kerschbaumer [:ckerschb]]

Aryx, would it be do-able to backout that change again, or do I have to write a reverse-patch? If do-able, could you please back it out for me?

Comment 8

[Atila Butkovits]

Backout on request by dev
Backout link: https://hg.mozilla.org/integration/autoland/rev/ba83bb6e6944857f38a03eee9935ba194e1645a8

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backout will be merged to central in 6-12 hours.

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backout merged: https://hg.mozilla.org/mozilla-central/rev/ba83bb6e6944

Comment 11

[Christoph Kerschbaumer [:ckerschb]]

There is no rigorous benefit of landing this patch if it causes problems. We have been using document->URI->SchemeIs("https") for a many years. Even though using potentially trustworthy was worth a shot I guess we just stick with what we have and mark this a WONTFIX.