1633351 - Captured credentials in the dismissed doorhanger are cleared upon editing the user/pass and clicking directly on key icon

Status: VERIFIED FIXED

(Toolkit :: Password Manager, defect, P1)

Description

[Timea Cernea [:tbabos][inactive]]

Attachment: Recording of the issue

Affected Versions:
Nightly 77.0a1 (2020-04-27)

Tested on:
Windows 10

Steps to reproduce:

1. Go to a login form (ex: facebook.com)
2. Fill in the username and password (username/password) and click out of the field
   observe the dismissed doorhanger key
3. Edit the username or the password and click directly on the grey key icon

Expected:
The captured credentials (username/password) should be displayed (prior to edit).

Actual:
The credentials appear for a split second and are cleared afterward.

Regression Range:
Mozregression revealed Bug 1629174 as the regressor.

Notes:
As of bug 1612258, the edits are not adjusted as the user types and it is required to click out of the field to capture the edits in the doorhanger. However, the initial credentials should still be displayed in the doorhanger, as it works in Beta76.

Comment 1

[Timea Cernea [:tbabos][inactive]]

Attachment: Log.txt

Comment 2

[Timea Cernea [:tbabos][inactive]]

Attachment: Password Generation

Also happens for auto-saved generated password doorhanger.

Comment 3

[Rachel Tublitz [:rachel]]

Hey Matt, would you mind setting a priority on this one?

Comment 4

[Matthew N. [:MattN]]

Attachment: Bug 1633351 - Revert doorhanger field clearing part of bug 1629174. r=sfoster

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ae293073d758
Revert doorhanger field clearing part of bug 1629174. r=sfoster

Comment 6

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/ae293073d758

Comment 7

[Timea Cernea [:tbabos][inactive]]

Verified-fixed on the latest Nightly 77.0a1 (2020-05-03) on Windows 10 x64, MacOS 10.13 and Ubuntu 16.04.

• verified both scenarios described in Comment 0 and Comment 2