1612258 - Show/adjust the dismissed login capture doorhanger in response to input events in the password & username field

Status: VERIFIED FIXED

(Toolkit :: Password Manager, enhancement, P2)

Description

[Sam Foster [:sfoster] (he/him)]

Bug 1536728 uses changes events to show a dismissed login capture doorhanger when the user edits a password field. If we use input events the doorhanger can be shown and updated in real-time to user input.

Comment 1

[Bianca Danforth [:bdanforth]]

Attachment: Bug 1612258 - Show/adjust the dismissed login capture doorhanger in response to input events in the password & username field. r=MattN

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2e37d9851441
Show/adjust the dismissed login capture doorhanger in response to input events in the password & username field. r=MattN,severin

Comment 3

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/2e37d9851441

Comment 4

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/2e37d9851441

Comment 5

[Bianca Danforth [:bdanforth]]

QA verification notes

Previous behavior
The dismissed doorhanger would not show up when editing a password input field until the field was blurred; i.e. it only showed up on "change"1 events.

New behavior
The dismissed doorhanger shows up when the field is edited, without requiring the field to be blurred; i.e. it shows on "input"2 events.

Unchanged behavior
As before, we expect the values of the username and password field (when the password field is non-empty) in the update/save doorhanger to match the values in the form.

Autosave of the initial fill and subsequent edits of generated passwords should also work as before; i.e. editing a generated password field will get autosaved on "change" events.

Known bugs that are out of scope

• Bug 1612257 (i.e. the behavior of the doorhanger when an edit clears the password field after a dismissed doorhanger was previously shown).
  • This should just behave the same way it did before this patch.

Comment 6

[Timea Cernea [:tbabos][inactive]]

Verified-fixed on the latest Firefox Nightly 80.0a1 (2020-07-14) (64-bit) on Windows 10, MacOS 10.13 and Ubuntu 16.04.

• the grey key icon is displayed right after starting to write in the password field and the values are captured and reflected in the dismissed doorhanger based on user input. There is no need to focus out of the field anymore as the updates are auto-made and correctly captured/displayed in the doorhanger
• the same behavior can be observed for editing filled in fields, dismissed doorhanger appears when the username or password is edited
• there are no changes or problems observed for password generation's save on the fly aspect
• Bug 1612257 is still reproducible and acknowledged as known issue