1633466 - Report usage of blocklist v3 to telemetry

Status: RESOLVED FIXED

(Toolkit :: Blocklist Implementation, task, P1)

Description

[Rob Wu [:robwu]]

In the parent bug (bug 1633403) I want to add some collection of data to observe the health of the blocklist v3 implementation. Those are expected to stay around indefinitely.

When we introduce blocklist v3, it will be behind a pref to allow users to toggle between the old and new implementation. We should report the value of extensions.blocklist.useMLBF in the telemetry. And probably also extensions.blocklist.useMLBF.stashes (which enables the stashing feature, which is a follow-up to the initial stashing implementation).

Comment 1

[:Gijs (out for now; he/him)]

Triaging, I'm assuming you'll be working on this? :-)

Comment 2

[Rob Wu [:robwu]]

Attachment: data-review-request-blocklist-v3-usage-telemetry.md

Comment 3

[mlopatka]

LGTM data steward review r+

Comment 4

[Rob Wu [:robwu]]

Thanks for the quick r+.

(linking to bug 1574441 since it's related and also mentioned in the data review doc itself)

Comment 5

[Rob Wu [:robwu]]

Attachment: Bug 1633466 - Record usage of blocklist v3 in telemetry

Although the data review request granted permission to keep the probes
for 6 months, I'm using a shorter expiration (81) so that all
blocklist-related telemetry can be coverd by one update request, in the
future.

"geckoview" is not listed yet, because blocklist v3 is not yet enabled
on mobile (bug 1639050). Once enabled, "geckoview" should be added to
every scalar from this commit.

Comment 6

[Rob Wu [:robwu]]

Attachment: Bug 1633466 - Move common test logic to test/xpcshell/rs-blocklist/head.js

And introduce a helper to get the ExtensionBlocklistMBLF global without
using a deprecated API, and remove the exception from eslintrc

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a4943c490a73
Move common test logic to test/xpcshell/rs-blocklist/head.js r=Gijs
https://hg.mozilla.org/integration/autoland/rev/e3bde0ccb270
Record usage of blocklist v3 in telemetry r=rpl,janerik

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/a4943c490a73
https://hg.mozilla.org/mozilla-central/rev/e3bde0ccb270

Comment 9

[Travis Long [:travis_]]

Comment on attachment 9149143 [details]
data-review-request-blocklist-v3-usage-telemetry.md

Data Review

1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?

Yes, through the Glean-Dictionary and the metric definition files

2. Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, through the standard telemetry preference

3. If the request is for permanent data collection, is there someone who will monitor the data over time?

Data to be collected for 6 months

4. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1

5. Is the data collection request for default-on or default-off?

Default-on

6. Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?

No

7. Is the data collection covered by the existing Firefox privacy notice?

Yes

8. Does the data collection use a third-party collection tool?

No

Result

data-review+