1640953 - Perma toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_blocklist_mlbf_telemetry.js | xpcshell return code: 0 | test_without_mlbf - [test_without_mlbf : 32] Got the expected value for blocklist.mlbf_stash_time_oldest scalar - "Sat, 16 May

Status: RESOLVED FIXED

(Toolkit :: Blocklist Implementation, defect, P1)

Description

[Treeherder Bug Filer]

Filed by: rmaries [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=303795420&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/L7cgH-nVSei5yGNxNzRu5g/runs/0/artifacts/public/logs/live_backing.log

---

[task 2020-05-26T16:15:01.275Z] 16:15:01 INFO - TEST-START | toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_blocklist_mlbf_telemetry.js
[task 2020-05-26T16:15:02.564Z] 16:15:02 WARNING - TEST-UNEXPECTED-FAIL | toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_blocklist_mlbf_telemetry.js | xpcshell return code: 0
[task 2020-05-26T16:15:02.564Z] 16:15:02 INFO - TEST-INFO took 1288ms
[task 2020-05-26T16:15:02.564Z] 16:15:02 INFO - >>>>>>>
[task 2020-05-26T16:15:02.564Z] 16:15:02 INFO - PID 19158 | [19158, Main Thread] WARNING: Couldn't get the user appdata directory. Crash events may not be produced.: file /builds/worker/checkouts/gecko/toolkit/crashreporter/nsExceptionHandler.cpp, line 2924
[task 2020-05-26T16:15:02.564Z] 16:15:02 INFO - TEST-PASS | toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_blocklist_mlbf_telemetry.js | undefined assertion name - blocklist.useMLBF should be true - true == true
[task 2020-05-26T16:15:02.565Z] 16:15:02 INFO - (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2020-05-26T16:15:02.565Z] 16:15:02 INFO - (xpcshell/head.js) | test run_next_test 0 pending (2)
[task 2020-05-26T16:15:02.565Z] 16:15:02 INFO - (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2020-05-26T16:15:02.589Z] 16:15:02 INFO - TEST-PASS | toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_blocklist_mlbf_telemetry.js | test_without_mlbf - [test_without_mlbf : 32] Got the expected value for blocklist.mlbf_stashes scalar - true == true
[task 2020-05-26T16:15:02.589Z] 16:15:02 INFO - TEST-PASS | toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_blocklist_mlbf_telemetry.js | test_without_mlbf - [test_without_mlbf : 32] Got the expected value for blocklist.mlbf_generation_time scalar - "Missing Date" == "Missing Date"
[task 2020-05-26T16:15:02.589Z] 16:15:02 WARNING - TEST-UNEXPECTED-FAIL | toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_blocklist_mlbf_telemetry.js | test_without_mlbf - [test_without_mlbf : 32] Got the expected value for blocklist.mlbf_stash_time_oldest scalar - "Sat, 16 May 2020 00:35:09 GMT" == "Missing Date"
[task 2020-05-26T16:15:02.590Z] 16:15:02 INFO - /builds/worker/workspace/build/tests/xpcshell/tests/toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_blocklist_mlbf_telemetry.js:assertTelemetryScalars:32
[task 2020-05-26T16:15:02.590Z] 16:15:02 INFO - /builds/worker/workspace/build/tests/xpcshell/tests/toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_blocklist_mlbf_telemetry.js:test_without_mlbf:70
[task 2020-05-26T16:15:02.591Z] 16:15:02 INFO - exiting test
[task 2020-05-26T16:15:02.591Z] 16:15:02 INFO - Unexpected exception NS_ERROR_ABORT:
[task 2020-05-26T16:15:02.592Z] 16:15:02 INFO - _abort_failed_test@/builds/worker/workspace/build/tests/xpcshell/head.js:833:20
[task 2020-05-26T16:15:02.592Z] 16:15:02 INFO - do_report_result@/builds/worker/workspace/build/tests/xpcshell/head.js:934:5
[task 2020-05-26T16:15:02.592Z] 16:15:02 INFO - Assert<@/builds/worker/workspace/build/tests/xpcshell/head.js:73:21
[task 2020-05-26T16:15:02.593Z] 16:15:02 INFO - proto.report@resource://testing-common/Assert.jsm:233:10
[task 2020-05-26T16:15:02.593Z] 16:15:02 INFO - equal@resource://testing-common/Assert.jsm:275:8
[task 2020-05-26T16:15:02.594Z] 16:15:02 INFO - assertTelemetryScalars@/builds/worker/workspace/build/tests/xpcshell/tests/toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_blocklist_mlbf_telemetry.js:32:10
[task 2020-05-26T16:15:02.594Z] 16:15:02 INFO - test_without_mlbf@/builds/worker/workspace/build/tests/xpcshell/tests/toolkit/mozapps/extensions/test/xpcshell/rs-blocklist/test_blocklist_mlbf_telemetry.js:70:25
[task 2020-05-26T16:15:02.597Z] 16:15:02 INFO - async*_run_next_test/<@/builds/worker/workspace/build/tests/xpcshell/head.js:1618:22
[task 2020-05-26T16:15:02.597Z] 16:15:02 INFO - _run_next_test@/builds/worker/workspace/build/tests/xpcshell/head.js:1618:38
[task 2020-05-26T16:15:02.597Z] 16:15:02 INFO - run@/builds/worker/workspace/build/tests/xpcshell/head.js:777:9
[task 2020-05-26T16:15:02.597Z] 16:15:02 INFO - _do_main@/builds/worker/workspace/build/tests/xpcshell/head.js:248:6
[task 2020-05-26T16:15:02.597Z] 16:15:02 INFO - _execute_test@/builds/worker/workspace/build/tests/xpcshell/head.js:577:5
[task 2020-05-26T16:15:02.597Z] 16:15:02 INFO - @-e:1:1
[task 2020-05-26T16:15:02.598Z] 16:15:02 INFO - exiting test
[task 2020-05-26T16:15:02.598Z] 16:15:02 INFO - "CONSOLE_MESSAGE: (error) [JavaScript Error: "NetworkError when attempting to fetch resource." {file: "/builds/worker/workspace/build/tests/xpcshell/head.js" line: 248}]
[task 2020-05-26T16:15:02.598Z] 16:15:02 INFO - _do_main@/builds/worker/workspace/build/tests/xpcshell/head.js:248:6
[task 2020-05-26T16:15:02.598Z] 16:15:02 INFO - _execute_test@/builds/worker/workspace/build/tests/xpcshell/head.js:577:5
[task 2020-05-26T16:15:02.598Z] 16:15:02 INFO - @-e:1:1

Comment 1

[Rob Wu [:robwu]]

Attachment: Bug 1640953 - Prevent RS dumps from being loaded in some blocklist tests

RemoteSettings helpfully falls back to loading from the JSON dumps when
the list of records is empty. This breaks tests that load an empty
blocklist, because unexpected records may appear.

Fix this by inserting a dummy value in the blocklist. Invalid records
should be ignored anyway, so this is a good way to prevent the dump from
being loaded.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c3a603ef2f09
Prevent RS dumps from being loaded in some blocklist tests r=gijs CLOSED TREE

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/c3a603ef2f09

Comment 4

[Rob Wu [:robwu]]

Although the test failure was triggered by an import of new blocklist data, the test itself was added in bug 1633466.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1633466

Comment 6

[Intermittent Failures Robot]

7 failures in 5458 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 7

Platform breakdown:

• macosx1014-64: 1
• macosx1014-64-shippable: 1
• linux1804-64: 1
• linux1804-64-shippable-qr: 2
• linux1804-64-shippable: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1640953&startday=2020-05-25&endday=2020-05-31&tree=all