Loss of focus after unselecting a selected recipient pill with Ctrl+Click blocks keyboard access to pills
Categories
(Thunderbird :: Message Compose Window, defect)
Tracking
(Not tracked)
People
(Reporter: thomas8, Assigned: thomas8)
References
(Blocks 1 open bug)
Details
(Keywords: access, ux-consistency)
Attachments
(1 file)
767 bytes,
patch
|
aleca
:
review+
|
Details | Diff | Splinter Review |
Loss of focus after unselecting a selected pill with Ctrl+Click. Focus must remain on the Ctrl-clicked pill. Loss of focus then prevents any further keyboard action on (selected/other) pills.
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Comment 1•4 years ago
|
||
The fix.
Not sure about the original purpose of pill.blur here?
From my analysis, (after this bug) the whole conditional was no longer needed (noop) , because we can't blur a pill which we know has focus either from mouse click (checkSelected claims to handle mouse events only) or from pressing " " on an already focused pill. Focus is already there (no need to focus), and it must stay right there (no need to blur).
Assignee | ||
Updated•4 years ago
|
Assignee | ||
Updated•4 years ago
|
Comment 2•4 years ago
|
||
Comment on attachment 9145535 [details] [diff] [review] 1633555_recipientPillCtrlClick.diff Review of attachment 9145535 [details] [diff] [review]: ----------------------------------------------------------------- That blur/focus condition was implemented right at the beginning, when tho whole focus/selected paradigm wasn't properly fledged out. You improved this part a lot, so that old condition was interfering. Good catch, thanks for fixing this.
Updated•4 years ago
|
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/06b4fa036ccd
Prevent loss of focus after Ctrl+Click on recipient pills. r=aleca
Assignee | ||
Comment 4•4 years ago
|
||
(In reply to Alessandro Castellani (:aleca) from comment #2)
Review of attachment 9145535 [details] [diff] [review]:
...
You improved this part a lot, so that old condition was interfering.
Good catch, thanks for fixing this.
Most welcome. I am here to help. Fast fix, fast check-in in comment 3... : great! :-)
Assignee | ||
Updated•4 years ago
|
Description
•