Closed
Bug 1633830
Opened 5 years ago
Closed 5 years ago
Reuse similar code pattern in PlaybackController
Categories
(Core :: Audio/Video: Playback, task, P1)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla78
| Tracking | Status | |
|---|---|---|
| firefox78 | --- | fixed |
People
(Reporter: alwu, Assigned: alwu)
References
Details
Attachments
(4 files)
There are some similar code being used in PlaybackController, we should reuse them to reduce the duplication.
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Comment 2•5 years ago
|
||
|
|
Assignee | |
Comment 3•5 years ago
|
||
|
|
Assignee | |
Comment 4•5 years ago
|
||
|
||
Updated•5 years ago
|
Attachment #9144120 -
Attachment description: Bug 1633830 - part2 : rename 'MediaActionHandler' to 'ContentMediaActionHandler'. → Bug 1633830 - part2 : rename `MediaActionHandler` to `ContentMediaActionHandler`.
|
|
||
Updated•5 years ago
|
Attachment #9144121 -
Attachment description: Bug 1633830 - part3 : rename 'PlaybackController' to 'ContentPlaybackController'. → Bug 1633830 - part3 : rename `PlaybackController` to `ContentPlaybackController`.
Pushed by alwu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ab4e693ca6a4
part1 : reuse duplicated code in PlaybackController. r=bryce
https://hg.mozilla.org/integration/autoland/rev/cb7d4c2d882f
part2 : rename `MediaActionHandler` to `ContentMediaActionHandler`. r=bryce
https://hg.mozilla.org/integration/autoland/rev/75bbd667a82d
part3 : rename `PlaybackController` to `ContentPlaybackController`. r=bryce
https://hg.mozilla.org/integration/autoland/rev/81ad56ec774f
part4 : update comment to describe the reason of having this class and remove out-of-date comment. r=bryce
|
||
Comment 6•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/ab4e693ca6a4
https://hg.mozilla.org/mozilla-central/rev/cb7d4c2d882f
https://hg.mozilla.org/mozilla-central/rev/75bbd667a82d
https://hg.mozilla.org/mozilla-central/rev/81ad56ec774f
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox78:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
You need to log in
before you can comment on or make changes to this bug.
Description
•