Closed Bug 1633889 Opened 5 years ago Closed 4 years ago

[perfdocs] Add test url to test description

Categories

(Testing :: Performance, task, P3)

Version 3
task

Tracking

(firefox80 fixed)

RESOLVED FIXED
mozilla80
Tracking Status
firefox80 --- fixed

People

(Reporter: sparky, Assigned: myeongjun.ko, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug)

User Story

https://wiki.mozilla.org/TestEngineering/Performance/NewContributors

Attachments

(1 file)

This bug is for adding the URL of the raptor pageload test to the test description.

Mentor: gmierz2
User Story: (updated)
Keywords: good-first-bug
Severity: -- → S3

Hello Sparky :)
I need checking before to go ahead.

Generated file[0] as follows:
* amazon (BT) (It's one example)

Is this Issue want to have result as follows?:
* amazon(https://www.amazon.com) (BT)

Description is already using. (i.e, BT ) [1]
So, Should I add new property on config.yml to solve it?
e.g)
amazon:
     description: "BT"
     url: "https://www.amazon.com"

If I think too hard or you have proper direction, Can you tell me about direction? :)
Thanks.

[0]
https://searchfox.org/mozilla-central/rev/82c04b9cad5b98bdf682bd477f2b1e3071b004ad/testing/perfdocs/generated/raptor.rst

[1]
https://searchfox.org/mozilla-central/rev/82c04b9cad5b98bdf682bd477f2b1e3071b004ad/testing/raptor/raptor/perfdocs/config.yml#41

Good start!

We can actually get the url without having it in the configuration file. This is where we open up the manifest which contains the url of the test: https://searchfox.org/mozilla-central/source/tools/lint/perfdocs/framework_gatherers.py#129

You can change it to gather those urls:

        subtest_list = {}
        for subtest in test_list:
            subtest_list[subtest["name"]] = subtest["manifest"]
            self.urls[subtest["name"]] = subtest["test_url"]

Then, below when you are building the description, you can search through that list of urls to find all matching urls:

        allmatchers = set()
        for name, url in self.urls.items():
            if title in name:
                allmatchers.add(url)

If there are multiple URLs for a particular title, then we'll have to split those out so they have one url each - the youtube-playback benchmark tests would be an exception to this rule. We'll also have to raise an exception if this happens.

Hello, can I work on this?

Hi Elaine! I'm sorry but :myeongjun is currently working on this bug.

We have some other bugs available in this list if you're interested.

This bug is a good one to start with though (the comment I link to has instructions for how to go about solving it): https://bugzilla.mozilla.org/show_bug.cgi?id=1629857#c2

If you have questions about it feel free to need-info me in that bug :)

Assignee: nobody → myeongjun.ko
Status: NEW → ASSIGNED

Thank you, I have requested to work on the bug that you have included in the link. (In reply to Greg Mierzwinski [:sparky] from comment #4)

Flags: needinfo?(gmierz2)
Flags: needinfo?(gmierz2)
Pushed by gmierz2@outlook.com: https://hg.mozilla.org/integration/autoland/rev/8183490c95d8 Add test url to test description r=sparky,perftest-reviewers
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla80
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: