[perfdocs] Add test url to test description
Categories
(Testing :: Performance, task, P3)
Tracking
(firefox80 fixed)
Tracking | Status | |
---|---|---|
firefox80 | --- | fixed |
People
(Reporter: sparky, Assigned: myeongjun.ko, Mentored)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug)
User Story
Attachments
(1 file)
This bug is for adding the URL of the raptor pageload test to the test description.
Reporter | ||
Updated•5 years ago
|
Updated•5 years ago
|
Assignee | ||
Comment 1•5 years ago
|
||
Hello Sparky :)
I need checking before to go ahead.
Generated file[0] as follows:
* amazon (BT)
(It's one example)
Is this Issue want to have result as follows?:
* amazon(https://www.amazon.com) (BT)
Description is already using. (i.e, BT
) [1]
So, Should I add new property on config.yml to solve it?
e.g)
amazon:
description: "BT"
url: "https://www.amazon.com"
If I think too hard or you have proper direction, Can you tell me about direction? :)
Thanks.
Reporter | ||
Comment 2•5 years ago
|
||
Good start!
We can actually get the url without having it in the configuration file. This is where we open up the manifest which contains the url of the test: https://searchfox.org/mozilla-central/source/tools/lint/perfdocs/framework_gatherers.py#129
You can change it to gather those urls:
subtest_list = {}
for subtest in test_list:
subtest_list[subtest["name"]] = subtest["manifest"]
self.urls[subtest["name"]] = subtest["test_url"]
Then, below when you are building the description, you can search through that list of urls to find all matching urls:
allmatchers = set()
for name, url in self.urls.items():
if title in name:
allmatchers.add(url)
If there are multiple URLs for a particular title, then we'll have to split those out so they have one url each - the youtube-playback benchmark tests would be an exception to this rule. We'll also have to raise an exception if this happens.
Comment 3•4 years ago
|
||
Hello, can I work on this?
Reporter | ||
Comment 4•4 years ago
|
||
Hi Elaine! I'm sorry but :myeongjun is currently working on this bug.
We have some other bugs available in this list if you're interested.
This bug is a good one to start with though (the comment I link to has instructions for how to go about solving it): https://bugzilla.mozilla.org/show_bug.cgi?id=1629857#c2
If you have questions about it feel free to need-info me in that bug :)
Comment 5•4 years ago
|
||
Thank you, I have requested to work on the bug that you have included in the link. (In reply to Greg Mierzwinski [:sparky] from comment #4)
Reporter | ||
Updated•4 years ago
|
Assignee | ||
Comment 6•4 years ago
|
||
Comment 8•4 years ago
|
||
bugherder |
Description
•