Open Bug 1633976 Opened 5 years ago Updated 2 years ago

Windows Flick Gestures & zoom reset not working since 47

Categories

(Core :: Widget: Win32, defect, P3)

47 Branch
defect

Tracking

()

UNCONFIRMED

People

(Reporter: info, Unassigned)

Details

(Whiteboard: [win:touch])

Attachments

(4 files)

Attached image ff-flicks.png

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:75.0) Gecko/20100101 Firefox/75.0

Steps to reproduce:

Ever since 52 changed the scrolling system, Flick Gestures (https://docs.microsoft.com/en-us/windows/win32/tablet/flicks-gestures) and zoom reset gesture stopped working.

To reproduce, get a Windows computer with a touchscreen.

Issue A with Flick gestures:

  1. Open Pen and Touch settings
  2. Setup Flick Gestures similarly to the attachment (I have 2 directions set to Back and 2 set to Forward, which navigates the browser)
  3. Try performing Back/Forward navigation using the gesture

Issue B with zoom reset:

  1. Zoom in/out on a webpage
  2. Tap the touchscreen with 2 fingers

Actual results:

In 52-75:

(Issue A) Gesture is ignored and causes scrolling instead
(Issue B) Nothing happens

Expected results:

In 51 and older:

(Issue A) Gesture triggers back/forward navigation
(Issue B) Zoom is reset to 100%

Component: Untriaged → Widget: Win32
Product: Firefox → Core

(In reply to chylex from comment #0)

Ever since 52 changed the scrolling system

Do you know the specific change that caused this by chance?

If not, would you be willing to use https://mozilla.github.io/mozregression/ to determine that?

Flags: needinfo?(info)
Attached file mozregression-log.txt
Unfortunately a bisect between 51 and 52 ended in a failure:

(In reply to chylex from comment #2)

Unfortunately a bisect between 51 and 52 ended in a failure:

Thanks. That failure is actually fine. It's because the builds are over a year old so they have been automatically cleaned. It just means mozregression couldn't narrow it down further but it got it narrowed down to a useful result

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=fd0564234eca242b7fb753a110312679020f8059&tochange=62f79d676e0e11b3ad59a5425b3ebb3ec5bbefb5

From that list I'm gonna guess bug 1297549.

Flags: needinfo?(aklotz)
Actually, with a clean profile mozregression made the flick gestures did not work in any build. Once I put my existing profile in, I could actually mark some builds as good and some as bad, uploading a new log. It showed the warnings and failed again, but the last 2 builds were 2016-10-19 (verdict: g) 2016-10-20 (verdict: b) I will investigate further to find out what in my profile is "fixing" the issue, and why that "fix" stopped working on 2016-10-20.

It appears that enabling, disabling, or removing any addon (even pure webext, although some legacy addons are installed in that profile) and restarting the browser breaks the flicks. Guessing it's some caching issue and the actual regression happened sometime before 51.

With a completely fresh profile, I narrowed it down to 2016-01-30 (verdict: g) 2016-01-31 (verdict: b) Range between first and last build from logs: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=54eea211e234&tochange=b2a3dc4b161f

I'm going to guess that it's caused by https://hg.mozilla.org/mozilla-central/rev/1056404c052eea689459638d6cb57fd888318a35

Try flipping the pref dom.w3c_touch_events.enabled

I'm guessing it's this one https://bugzilla.mozilla.org/show_bug.cgi?id=1180706

Reverting dom.w3c_touch_events.enabled back to 0 and restarting the browser fixes the issue in older versions, unfortunately that no longer works in 75.

Running another mozregression to find out where the workaround stops working comes up with:
2017-03-01 (verdict: g)
2017-03-02 (verdict: b)
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=34c6c2f302e7b48e3ad2cec575cbd34d423a9d32&tochange=e91de6fb2b3dce9c932428265b0fdb630ea470d7

Flags: needinfo?(info)
Summary: Windows Flick Gestures & zoom reset not working since 52 → Windows Flick Gestures & zoom reset not working since 47
Version: 52 Branch → 47 Branch

Because this bug's Severity has not been changed from the default since it was filed, and it's Priority is -- (non,) indicating it has has not been previously triaged, the bug's Severity is being updated to -- (default, untriaged.)

Severity: normal → --

The priority flag is not set for this bug.
:jimm, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(jmathies)
Flags: needinfo?(jmathies)
Priority: -- → P3
Severity: -- → S3
Whiteboard: [win:touch]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: