[meta] Touch support in APZ on desktop platforms

RESOLVED FIXED in Firefox 47

Status

()

Core
Panning and Zooming
RESOLVED FIXED
2 years ago
26 days ago

People

(Reporter: kats, Assigned: kats)

Tracking

(Blocks: 2 bugs, {dev-doc-needed, site-compat})

unspecified
mozilla47
dev-doc-needed, site-compat
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox47 fixed)

Details

(Whiteboard: [gfx-noted])

Attachments

(1 attachment)

Just a meta bug to group all the things related to supporting touch input on desktop platforms once APZ is live. I'm not yet sure of the dependency chain here.

Updated

2 years ago
Whiteboard: [gfx-noted]
Duplicate of this bug: 548005
Depends on: 1204250
No longer depends on: 736048, 789906, 1204250, 978679
Blocks: 1187439, 1013364
Blocks: 1166732
Created attachment 8713677 [details] [diff] [review]
Patch

Tests are looking green, https://treeherder.mozilla.org/#/jobs?repo=try&revision=87b78b065d7e&group_state=expanded

I haven't actually tested this patch locally on my Windows touch device, but I can do that this weekend and land the patch after that. I'd prefer to leave this riding the train on 47 so it gets the normal amount of bake time, rather than uplifting it to 46 to go with the rest of APZ.
Assignee: nobody → bugmail.mozilla
Attachment #8713677 - Flags: review?(botond)
Comment on attachment 8713677 [details] [diff] [review]
Patch

Review of attachment 8713677 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! r+ assuming the testing checks out.
Attachment #8713677 - Flags: review?(botond) → review+
So it turns out that touch scrolling *does* actually work in Windows right now. Without e10s/APZ, you can touch-scroll although it's the windows widget touch gesture goop that is driving it. No touch events are delivered to the web content. Scrolling has inertia. With e10s (with or without APZ), the same is true, except scrolling has no inertia (that's what bug 1187439 is). With e10s and APZ you can additionally turn on dom.w3c_touch_events.enabled=2 and then you get APZ touch scrolling which is the best scrolling of them all.

So I'm going to land this patch, but going to do it #ifdef NIGHTLY for now because it also causes the window.Touch and related stuff to become accessible to web content. That's a fairly large change in that sites might be using that to autodetect mobile vs desktop and there might be some fallout. I also want to get the desktop UX team to tweak the touch physics because it seems a bit sluggish, and in case they don't get around to in 47 I don't want this accidentally riding the trains.

Comment 5

a year ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/1056404c052e
Blocks: 1244402

Comment 6

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/1056404c052e
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox47: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Blocks: 674371
Blocks: 688990
No longer blocks: 674371
No longer blocks: 688990
Keywords: dev-doc-needed, site-compat
No longer blocks: 1166732
Depends on: 1250024
Depends on: 1272268
(Assignee)

Updated

10 months ago
Duplicate of this bug: 1285335
(Assignee)

Updated

9 months ago
Blocks: 1272268
No longer depends on: 1272268

Updated

8 months ago
Depends on: 1301175
Depends on: 1322349
Depends on: 1147335
(Assignee)

Updated

4 months ago
Depends on: 1328285
Depends on: 1342895
Depends on: 1345355
You need to log in before you can comment on or make changes to this bug.