Closed Bug 1634030 Opened 5 months ago Closed 2 months ago

Lazify the main hamburger panel

Categories

(Firefox :: Toolbars and Customization, task, P3)

task

Tracking

()

RESOLVED FIXED
81 Branch
Tracking Status
firefox77 --- wontfix
firefox81 --- fixed

People

(Reporter: Gijs, Assigned: emalysz)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxperf:p2])

Attachments

(1 file, 5 obsolete files)

This is <panel id="appMenu-popup">.

It's a bit tricky to lazify this. The main code interacting with it is in PanelUI.js, but there are various other bits of code that rely on it or parts of it throughout browser/. Particularly the fact that it contains panelview nodes that may be needed for other buttons that show panels (like the developer tools button and the library button) might make this tricky.

On the other hand, given the size of what it contains, this is probably the biggest-bang-for-our-buck part of bug 1624683.

Perhaps we can wrap it all in a template, use the PanelUI.popup accessor to de-lazify it, update the code in PanelUI.js to not need direct access to it until it's delazified, and add a test that this doesn't happen in a new window by the time the idle tasks for the new window have run, and then systematically eliminate/lazify accesses that require the accessor.

Severity: -- → N/A
Whiteboard: [fxperf] → [fxperf:p2]
Assignee: nobody → emalysz
Attached file Bug 1634030: lazify main app menu (obsolete) —
Depends on: 1648175

Comment on attachment 9157817 [details]
Bug 1634030, remove history and library panel views from the main panel and place in template

Revision D80306 was moved to bug 1648175. Setting attachment 9157817 [details] to obsolete.

Attachment #9157817 - Attachment is obsolete: true
Depends on: 1648198

Comment on attachment 9158662 [details]
Bug 1634030: Remove recently closed tabs and windows panels from main view and place in template

Revision D80717 was moved to bug 1648198. Setting attachment 9158662 [details] to obsolete.

Attachment #9158662 - Attachment is obsolete: true
Attachment #9158727 - Attachment is obsolete: true
Depends on: 1648613
Depends on: 1648636
Depends on: 1648637
Depends on: 1648638
Depends on: 1648639
Depends on: 1648640
Attachment #9158744 - Attachment is obsolete: true
Attachment #9156759 - Attachment is obsolete: true
Flags: needinfo?(emalysz)
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch
Regressions: 1660201
Regressions: 1662183
You need to log in before you can comment on or make changes to this bug.