1634030 - Lazify the main hamburger panel

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, task, P3)

Description

[:Gijs (he/him)]

This is <panel id="appMenu-popup">.

It's a bit tricky to lazify this. The main code interacting with it is in PanelUI.js, but there are various other bits of code that rely on it or parts of it throughout browser/. Particularly the fact that it contains panelview nodes that may be needed for other buttons that show panels (like the developer tools button and the library button) might make this tricky.

On the other hand, given the size of what it contains, this is probably the biggest-bang-for-our-buck part of bug 1624683.

Perhaps we can wrap it all in a template, use the PanelUI.popup accessor to de-lazify it, update the code in PanelUI.js to not need direct access to it until it's delazified, and add a test that this doesn't happen in a new window by the time the idle tasks for the new window have run, and then systematically eliminate/lazify accesses that require the accessor.

Comment 1

[Emma Malysz]

Attachment: Bug 1634030: lazify main app menu

Comment 2

[Emma Malysz]

Attachment: Bug 1634030, remove history and library panel views from the main panel and place in template

Comment 3

[Emma Malysz]

Attachment: Bug 1634030: Remove recently closed tabs and windows panels from main view and place in template

Comment 4

[Emma Malysz]

Attachment: Bug 1634030: remove bookmark, containers, help, and developer views from main panel and place in template

Comment 5

[Emma Malysz]

Attachment: Bug 1634030: remove profiler, character encoding, panic view, more view, ssb view, and bookmarking tools panels from main view and place in template

Comment 6

[Phabricator Automation]

Comment on attachment 9157817 [details]
Bug 1634030, remove history and library panel views from the main panel and place in template

Revision D80306 was moved to bug 1648175. Setting attachment 9157817 [details] to obsolete.

Comment 7

[Phabricator Automation]

Comment on attachment 9158662 [details]
Bug 1634030: Remove recently closed tabs and windows panels from main view and place in template

Revision D80717 was moved to bug 1648198. Setting attachment 9158662 [details] to obsolete.

Comment 8

[Emma Malysz]

Attachment: Bug 1634030: lazify main app menu

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e71e10688704
lazify main app menu r=Gijs

Comment 10

[Atila Butkovits]

Backed outfor failure at browser_shim_disable_devtools.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/0223d17731fc0c0eee34949c49c99ba6548898a1

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedTaskRun=f-PCbmGJSTyibC007czEXw.0&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&searchStr=dt3&revision=e71e106887040c9c31244b7e4199b6d6ec3ef21f

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=312452114&repo=autoland&lineNumber=19848

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c9872975bb5d
lazify main app menu r=Gijs

Comment 12

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/c9872975bb5d