1634237 - `TypeError: can't access property "scrollIntoView", selectedRow is null` when opening the All Tabs panel with a pinned tab selected

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect, P3)

Description

[kernp25]

Attachment: firefox_OFq8oNTPQr.png

https://searchfox.org/mozilla-central/rev/7fd1c1c34923ece7ad8c822bee062dd0491d64dc/browser/base/content/browser-allTabsMenu.js#80

Just saw this error in browser console.
I will try to reproduce.

Comment 1

[kernp25]

My browser: 77.0a1 (2020-04-28) (64-Bit)

Comment 2

[Rares Doghi, Desktop QA]

Hi kernp25 if you do manage to reproduce this issue can you please provide some steps and maybe a reduced case where we can reproduce it on our end as well ?

Comment 3

[kernp25]

It seems to happen, if the current/active tab is pinned.

STR:

1. Open a new tab
2. Pin the new tab
3. Click on the all tabs button

Comment 4

[Rares Doghi, Desktop QA]

Thanks for the steps kernp25, I was able to get a regression range and it seems that this is the First Bad build:

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=32d6e8a34f39f8f00e2eae7fd1b01186f80e182c&tochange=e8d220dbe0299d90441b3dce6587a5b174f24644

It seems Bug 1259822 might be the cause of it.

Older builds would only show the "Selected row is null" error when clicking the "all tabs" button.

I did another regression range for when I wouldnt see any errors in Browser Console and here are the results:

Last known good:
app_name: firefox
build_date: 2018-06-22
build_file: C:\Users\rares.doghi.mozilla\mozregression\persist\2018-06-22--mozilla-central--firefox-62.0a1.en-US.win64.zip
build_type: nightly
build_url: https://archive.mozilla.org/pub/firefox/nightly/2018/06/2018-06-22-22-01-19-mozilla-central/firefox-62.0a1.en-US.win64.zip
changeset: 16a0430796894ad4b9cb86bde55f07cf57453b56
pushlog_url: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=16a0430796894ad4b9cb86bde55f07cf57453b56&tochange=1c235a552c32ba6c97e6030c497c49f72c7d48a8
repo_name: mozilla-central
repo_url: https://hg.mozilla.org/mozilla-central

First known bad:
app_name: firefox
build_date: 2018-06-23
build_file: C:\Users\rares.doghi.mozilla\mozregression\persist\2018-06-23--mozilla-central--firefox-62.0a1.en-US.win64.zip
build_type: nightly
build_url: https://archive.mozilla.org/pub/firefox/nightly/2018/06/2018-06-23-22-01-15-mozilla-central/firefox-62.0a1.en-US.win64.zip
changeset: 5dc06b87c88ef4707aeebdd9f8b8c6935edda0c4
pushlog_url: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=16a0430796894ad4b9cb86bde55f07cf57453b56&tochange=5dc06b87c88ef4707aeebdd9f8b8c6935edda0c4
repo_name: mozilla-central
repo_url: https://hg.mozilla.org/mozilla-central

I would have gone deeper but ther was not enough data to bisect.

Comment 5

[Shane Hughes [:aminomancer]]

Attachment: Bug 1634237 - Resolve a benign error in the All Tabs Menu. r?dao

The All Tabs Menu tries to scroll the selected tab element into view
when the All Tabs view is shown. But depending on user prefs, pinned
tabs are elided from the menu, resulting in no selected tab element.
So this can invoke undefined.scrollIntoView and result in an error.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6165859eb269
Resolve a benign error in the All Tabs Menu. r=dao

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/6165859eb269

Comment 8

[Rares Doghi, Desktop QA]

This issue is Verified as Fixed in our latest build 99.0a1 (2022-02-10).