Open Bug 1634325 Opened 6 years ago Updated 1 year ago

New wpt failures in /css/css-grid/alignment/self-baseline/ [grid-self-baseline-horiz-007.html, grid-self-baseline-vertical-lr-007.html, grid-self-baseline-vertical-rl-007.html, etc]

Categories

(Core :: Layout: Grid, defect)

Product:
Core
Component:
Layout: Grid
Type:
defect

Tracking

()

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [wpt])

Syncing wpt PR 23066 found new untriaged test failures in CI

Tests Affected

Firefox-only failures

/css/css-grid/alignment/self-baseline/grid-self-baseline-006.html: FAIL
/css/css-grid/alignment/self-baseline/grid-self-baseline-002-b.html: FAIL
/css/css-grid/alignment/self-baseline/grid-self-baseline-vertical-lr-007.html: FAIL
/css/css-grid/alignment/self-baseline/grid-self-baseline-vertical-rl-002.html: FAIL
/css/css-grid/alignment/self-baseline/grid-self-baseline-004.html: FAIL
/css/css-grid/alignment/self-baseline/grid-self-baseline-horiz-007.html: FAIL
/css/css-grid/alignment/self-baseline/grid-self-baseline-003.html: FAIL
/css/css-grid/alignment/self-baseline/grid-self-baseline-007.html: FAIL
/css/css-grid/alignment/self-baseline/grid-self-baseline-vertical-rl-003.html: FAIL
/css/css-grid/alignment/self-baseline/grid-self-baseline-002.html: FAIL

New Tests That Don't Pass

/css/css-grid/alignment/self-baseline/grid-self-baseline-vertical-lr-004.html: FAIL [Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt], PASS [Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, GitHub] (Chrome: PASS, Safari: PASS)
/css/css-grid/alignment/self-baseline/grid-self-baseline-vertical-rl-004.html: FAIL [Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt], PASS [Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, GitHub] (Chrome: PASS, Safari: PASS)

CI Results

Gecko CI (Treeherder)
GitHub PR Head

Notes

These updates will be on mozilla-central once bug 1631030 lands.

Note: this bug is for tracking fixing the issues and is not
owned by the wpt sync bot.

This bug is linked to the relevant tests by an annotation in
https://github.com/web-platform-tests/wpt-metadata. These annotations
can be edited using the wpt interop dashboard
https://jgraham.github.io/wptdash/

If this bug is split into multiple bugs, please also update the
annotations, otherwise we are unable to track which wpt issues are
already triaged. Resolving as duplicate or closing this issue should
be cause the bot to automatically update or remove the annotation.

The priority flag is not set for this bug.
:svoisen, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(svoisen)
Severity: -- → S4
Flags: needinfo?(svoisen)

For one of the tests, here are...
wpt.fyi: https://wpt.fyi/results/css/css-grid/alignment/self-baseline/grid-self-baseline-horiz-005.html
testcase: http://wpt.live/css/css-grid/alignment/self-baseline/grid-self-baseline-horiz-005.html
reference case: http://wpt.live/css/css-grid/alignment/self-baseline/grid-self-baseline-horiz-005-ref.html

Safari and Firefox seem to agree here (and have pretty-different baseline alignment behavior between testcase vs. reference case).
Chrome matches the test expectation.

Haven't looked closely enough yet to know who's right or what's going on precisely.

Blocks: interop-2024-layout

(In reply to Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org) from comment #0)

/css/css-grid/alignment/self-baseline/grid-self-baseline-002-b.html: FAIL
[...]
/css/css-grid/alignment/self-baseline/grid-self-baseline-002.html: FAIL

Minor update: we're passing these two tests now, as of bug 1906901 (which removed the .ini file with the expected-failure annotation for these two tests, in this commit.

It looks like we've still got expected-failure annotations for the rest of the tests listed in comment 0, though (based on looking at the .ini files that exist in https://searchfox.org/mozilla-central/source/testing/web-platform/meta/css/css-grid/alignment/self-baseline )

Summary: New wpt failures in /css/css-grid/alignment/self-baseline/ [grid-self-baseline-006.html, grid-self-baseline-002-b.html, grid-self-baseline-vertical-lr-004.html, and 9 others] → New wpt failures in /css/css-grid/alignment/self-baseline/ [grid-self-baseline-006.html, grid-self-baseline-vertical-lr-004.html, etc]

Update: we are passing the following as of Bug 1977501 and with layout.css.grid-multi-pass-track-sizing.enabled=true.

  • testing/web-platform/meta/css/css-grid/alignment/self-baseline/grid-self-baseline-008.html
  • testing/web-platform/meta/css/css-grid/alignment/self-baseline/grid-self-baseline-changes-grid-area-size-007.html
  • testing/web-platform/meta/css/css-grid/alignment/self-baseline/grid-self-baseline-changes-grid-area-size-008.html
  • testing/web-platform/meta/css/css-grid/alignment/self-baseline/grid-self-baseline-changes-grid-area-size-010.html
  • testing/web-platform/meta/css/css-grid/alignment/self-baseline/grid-self-baseline-changes-grid-area-size-011.html
Summary: New wpt failures in /css/css-grid/alignment/self-baseline/ [grid-self-baseline-006.html, grid-self-baseline-vertical-lr-004.html, etc] → New wpt failures in /css/css-grid/alignment/self-baseline/ [grid-self-baseline-horiz-007.html, grid-self-baseline-vertical-lr-007.html, grid-self-baseline-vertical-rl-007.html, etc]
You need to log in before you can comment on or make changes to this bug.