Closed
Bug 1634514
Opened 5 years ago
Closed 5 years ago
Convert all relevant uses of left/right/top/bottom to logical properties in panelUI.css
Categories
(Thunderbird :: Theme, task)
Thunderbird
Theme
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 77.0
People
(Reporter: Paenglab, Assigned: Paenglab)
Details
Attachments
(1 file, 1 obsolete file)
|
3.94 KB,
patch
|
Paenglab
:
review+
|
Details | Diff | Splinter Review |
In panelUI.css we have still some -inline-left/-inline-right etc. we can convert to *-inline or *-block.
|
Assignee | |
Comment 1•5 years ago
|
||
Convert them and remove a redundant .PanelUI-subView toolbarseparator rule.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9144801 -
Flags: review?(alessandro)
|
||
Comment 2•5 years ago
|
||
Comment on attachment 9144801 [details] [diff] [review]
1634514-convert-left-right.patch
Review of attachment 9144801 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks for this clean up.
Can you update the comment with:
"Bug 1634514 - Convert all relevant uses of margin and padding left/right/top/bottom to logical properties in panelUI.css. r=aleca"
Attachment #9144801 -
Flags: review?(alessandro) → review+
|
|
Assignee | |
Comment 3•5 years ago
|
||
Updated the comment.
Attachment #9144801 -
Attachment is obsolete: true
Attachment #9144956 -
Flags: review+
|
|
Assignee | |
Updated•5 years ago
|
Keywords: checkin-needed-tb
Target Milestone: --- → Thunderbird 77.0
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/4c595cb3f7f5
Convert all relevant uses of margin and padding left/right/top/bottom to logical properties in panelUI.css. r=aleca DONTBUILD
You need to log in
before you can comment on or make changes to this bug.
Description
•