Closed Bug 1634693 Opened 5 years ago Closed 11 months ago

Page load events should be emitted when navigating to a file: url

Categories

(Remote Protocol :: CDP, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: impossibus, Unassigned)

References

Details

(Whiteboard: [puppeteer-beta2-mvp])

We don't emit any events in this case.

Example of expected events:

            Page.navigate({"url":"file:///home/maja/dev/mozilla-unified/remote/test/browser/page/doc_empty.html"})
Network.requestWillBeSent({"documentURL":"file:///home/maja/dev/mozilla-unified/remote/test/browser/page/doc_empty.html","frameId":"200D0C2CAF29E73EC1EFE43577856DAB","hasUserGesture":false,"initiator":{"type":"other"},"loaderId":"BBCEC6032D3B8C7AD1A9B2DA5954C9F5","request":{"headers":{},"initialPriority":"VeryHigh","method":"GET","mixedContentType":"none","referrerPolicy":"no-referrer-when-downgrade","url":"file:///home/maja/dev/mozilla-unified/remote/test/browser/page/doc_empty.html"},"requestId":"BBCEC6032D3B8C7AD1A9B2DA5954C9F5","timestamp":129913.578746,"type":"Document","wallTime":1588341412.801628})
 Network.responseReceived({"frameId":"200D0C2CAF29E73EC1EFE43577856DAB","loaderId":"BBCEC6032D3B8C7AD1A9B2DA5954C9F5","requestId":"BBCEC6032D3B8C7AD1A9B2DA5954C9F5","response":{"connectionId":0,"connectionReused":false,"encodedDataLength":-1,"fromDiskCache":false,"fromPrefetchCache":false,"fromServiceWorker":false,"headers":{},"mimeType":"text/html","protocol":"file","remoteIPAddress":"","remotePort":0,"securityState":"secure","status":0,"statusText":"","url":"file:///home/maja/dev/mozilla-unified/remote/test/browser/page/doc_empty.html"},"timestamp":129913.580867,"type":"Document"})
            Page.navigate({"url":"file:///home/maja/dev/mozilla-unified/remote/test/browser/page/doc_empty.html"}) = {"frameId":"200D0C2CAF29E73EC1EFE43577856DAB","loaderId":"BBCEC6032D3B8C7AD1A9B2DA5954C9F5"}
 Page.frameStartedLoading({"frameId":"200D0C2CAF29E73EC1EFE43577856DAB"})
      Page.frameNavigated({"frame":{"id":"200D0C2CAF29E73EC1EFE43577856DAB","loaderId":"BBCEC6032D3B8C7AD1A9B2DA5954C9F5","mimeType":"text/html","securityOrigin":"file://","url":"file:///home/maja/dev/mozilla-unified/remote/test/browser/page/doc_empty.html"}})
     Network.dataReceived({"dataLength":89,"encodedDataLength":0,"requestId":"BBCEC6032D3B8C7AD1A9B2DA5954C9F5","timestamp":129913.586716})
  Network.loadingFinished({"encodedDataLength":89,"requestId":"BBCEC6032D3B8C7AD1A9B2DA5954C9F5","shouldReportCorbBlocking":false,"timestamp":129913.580394})
      Page.loadEventFired({"timestamp":129913.59224})
 Page.frameStoppedLoading({"frameId":"200D0C2CAF29E73EC1EFE43577856DAB"})
Page.domContentEventFired({"timestamp":129913.592547})

Maja, your example above doesn't show any lifecycle event, but just page load events. Maybe you used the wrong term in the bug summary?

Flags: needinfo?(mjzffr)
Flags: needinfo?(mjzffr)
Summary: Page lifecycle events should be emitted when navigating to a file: url → Page events should be emitted when navigating to a file: url

Yeah, I mean the general term "page life cycle" (for load, DOMContentloaded) rather than the CDP-specific Page.lifecycleEvent

Summary: Page events should be emitted when navigating to a file: url → Page load events should be emitted when navigating to a file: url
Priority: -- → P3
No longer blocks: 1549515

Maybe wrapping the request into a new http channel might give us some events? There is code in devtools we could have a look at:
https://searchfox.org/mozilla-central/rev/df4c90d4b8c92c99f76334acfe4813c573c12661/devtools/shared/DevToolsUtils.js#673

Whiteboard: [puppeteer-beta2-mvp]
Component: CDP: Page → CDP
Severity: -- → S3

We are not going to implement support for this for our CDP implementation.

Status: NEW → RESOLVED
Closed: 11 months ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.