1634788 - build-clang shouldn't symlink repos anymore

Status: RESOLVED DUPLICATE of bug 1774554

(Firefox Build System :: Toolchains, defect, P3)

Description

[(Away)]

The symlinks are a leftover from the multi-repo SVN times. Nowadays the monorepo knows what to do.

This makes build-clang not produce the same results as a local cmake invocation. This caused me a lot of lost time and frustration today while trying to track down this difference.

Once we remove the symlinks, the build will be controlled by LLVM_ENABLE_PROJECTS, which means we'll also have to fix up last-stage builds to set that variable, otherwise we'll only build core LLVM.

While we're here, LLVM_TOOL_LIBCXX_BUILD=ON is also outdated, that too should be controlled by LLVM_ENABLE_PROJECTS.

Comment 1

[Mike Hommey [:glandium]]

Don't forget we still build clang 5.0 with that script.