1634863 - LastModifiedDate not set on addressbook cards (and addressbooks)

Status: RESOLVED FIXED

(Thunderbird :: Address Book, defect)

Description

[Günter Gersdorf]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:75.0) Gecko/20100101 Firefox/75.0

Steps to reproduce:

Edit an addressbook card or call card.setProperty('LastModifiedDate', timestamp);

Actual results:

Nothing.
card.getProperty('LastModifiedDate', default) returns either 0 or a time, set on the card with TB68

Expected results:

card.getProperty('LastModifiedDate', default) should return an actual time
This happens at least since TB72.

lastModifiedDate of an nsIAbDirectory was never set (since TB2?)

Comment 1

[Firefox Bug Husbandry Bot]

Because this bug's Severity has not been changed from the default since it was filed, and it's Priority is -- (non,) indicating it has has not been previously triaged, the bug's Severity is being updated to -- (default, untriaged.)

Comment 2

[Wayne Mery (:wsmwk)]

regression?

Comment 3

[Geoff Lankow (:darktrojan)]

Attachment: 1634863-lastmodifieddate-1.diff

I've been vaguely aware of this for a while, just never got around to dealing with it.

Comment 4

[Khushil Mistry [:khushil324]]

Comment on attachment 9163726 [details] [diff] [review]
1634863-lastmodifieddate-1.diff

Review of attachment 9163726 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. Send it for a try-run before merging. I have run unit test and it passed.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/6e970f979fcc
Save the LastModifiedDate on addressbook cards. r=khushil

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9163726 [details] [diff] [review]
1634863-lastmodifieddate-1.diff

Approved for beta and thanks for doing the tests

Comment 7

[Rob Lemley [:rjl]]

Thunderbird 79.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/83f8718cb32a

Comment 8

[Geoff Lankow (:darktrojan)]

Comment on attachment 9163726 [details] [diff] [review]
1634863-lastmodifieddate-1.diff

There's a slight risk to this but I think any serious problems would've shown up in the time it's had on beta.

Comment 9

[Wayne Mery (:wsmwk)]

Comment on attachment 9163726 [details] [diff] [review]
1634863-lastmodifieddate-1.diff

Approved for esr78

Comment 10

[Rob Lemley [:rjl]]

Thunderbird 78.1.0:
https://hg.mozilla.org/releases/comm-esr78/rev/2ac6f6488701