1635015 - Crash in [@ mozilla::layers::CanvasTranslator::Flush]

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Gabriele Svelto [:gsvelto] (PTO)]

This bug is for crash report bp-a852f0ed-ada3-4a40-87cf-7d5ab0200502.

Top 10 frames of crashing thread:

0 xul.dll mozilla::layers::CanvasTranslator::Flush gfx/layers/ipc/CanvasTranslator.cpp:276
1 xul.dll mozilla::layers::CanvasTranslator::TranslateRecording gfx/layers/ipc/CanvasTranslator.cpp:231
2 xul.dll mozilla::layers::CanvasTranslator::StartTranslation gfx/layers/ipc/CanvasTranslator.cpp:154
3 xul.dll mozilla::detail::RunnableMethodImpl< xpcom/threads/nsThreadUtils.h:1220
4 xul.dll mozilla::TaskQueue::Runner::Run xpcom/threads/TaskQueue.cpp:208
5 xul.dll nsThreadPool::Run xpcom/threads/nsThreadPool.cpp:300
6 xul.dll nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:1200
7 xul.dll NS_ProcessNextEvent xpcom/threads/nsThreadUtils.cpp:481
8 xul.dll mozilla::ipc::MessagePumpForNonMainThreads::Run ipc/glue/MessagePump.cpp:302
9 xul.dll MessageLoop::RunHandler ipc/chromium/src/base/message_loop.cc:308

This is NULL pointer dereference with the value probably coming from the mDevices field. The oldest buildid for this crash is 20200416214356. There are three crash reports coming from nightly 72 but they're orphaned (i.e. they lack metadata) so I would ignore them because the version number is taken from the browser that sent the crash, not the one where the crash happened.

Comment 1

[Bob Owen (:bobowen)]

Looks like I just need to add a null check in here.
I imagine this can happen if we have a device reset and then fail (or decide not to) create a new one.

Comment 2

[Bob Owen (:bobowen)]

Attachment: Bug 1635015: Add mDevice null check to CanvasTranslator::Flush. r=mattwoodrow!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fb4a0e72e2ad
Add mDevice null check to CanvasTranslator::Flush. r=mattwoodrow

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/fb4a0e72e2ad