1635016 - Crash in [@ webrender::renderer::Renderer::update] DebugCommand::SetPictureTileSize()

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P3)

Description

[Gabriele Svelto [:gsvelto]]

This bug is for crash report bp-92de8fbe-d0a3-46dd-83b3-e27c20200503.

Top 10 frames of crashing thread:

0 xul.dll RustMozCrash mozglue/static/rust/wrappers.cpp:16
1 xul.dll mozglue_static::panic_hook mozglue/static/rust/lib.rs:89
2 xul.dll core::ops::function::Fn::call<fn ../f3e1a954d2ead4e2fc197c7da7d71e6c61bad196/src/libcore/ops/function.rs:232
3 xul.dll std::panicking::rust_panic_with_hook ../f3e1a954d2ead4e2fc197c7da7d71e6c61bad196//src/libstd/panicking.rs:475
4 xul.dll std::panicking::begin_panic<str*> ../f3e1a954d2ead4e2fc197c7da7d71e6c61bad196/src/libstd/panicking.rs:404
5 xul.dll webrender::renderer::Renderer::update gfx/wr/webrender/src/renderer.rs:2892
6 xul.dll mozilla::detail::RunnableMethodImpl<RefPtr<mozilla::AbstractCanonical<RefPtr<AudioDeviceInfo> > >, void  xpcom/threads/nsThreadUtils.h:1220
7 xul.dll MessageLoop::DoWork ipc/chromium/src/base/message_loop.cc:523
8 xul.dll base::MessagePumpDefault::Run ipc/chromium/src/base/message_pump_default.cc:35
9 xul.dll MessageLoop::RunHandler ipc/chromium/src/base/message_loop.cc:308

We're crashing here. This is happening both on Windows and Linux. The oldest buildid for this crash is 20200423095248. Disregard the crashes that aren't on versions earlier than nightly 77 because they're unrelated.

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Weird. Any thoughts Glenn?

Comment 2

[Glenn Watson [:gw]]

I haven't looked in any detail, but I wonder if it might be related to the scene building threading refactoring that Nical is working on?

Comment 3

[Nicolas Silva [:nical]]

I haven't looked in any detail, but I wonder if it might be related to the scene building threading refactoring that Nical is working on?

Indeed. I removed the transaction logging code recently-ish and DebugCommand::SetTransactionLogging now passes through the render backend without being handled.

It looks like SetTransactionLogging should be removed as well.

Comment 4

[Nicolas Silva [:nical]]

Attachment: Bug 1635016 - Remove the rest of the SetTransactionLogging glue. r=jrmuizel

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:jbonisteel, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0cf175ec013b
Remove the rest of the SetTransactionLogging glue. r=jrmuizel

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/0cf175ec013b