1635105 - Firefox becomes unresponsive when more tools is closed while having search bar and forget window opened

Status: NEW

(Firefox :: Toolbars and Customization, defect, P3)

Description

[Alexandru Trif, Desktop QA [:atrif]]

Attachment: freeze.gif

Affected versions

• 77.0a1 (20200503214759)
• 76.0 (20200429185419)
• 75.0 (20200403170909)

Affected platforms

• Windows 10x64

Preconditions

• Have the search bar and forget options added to the overflow menu from Customize.

Steps to reproduce

1. Open Firefox and click on the More tools menu.
2. Select the search bar and type a random word.
3. Click on the Forget option.
4. Select the More tools option again from the URL bar.

Expected result

• Overflow menu is closed and no freeze occurs.

Actual result

• Firefox becomes unresponsive and this error is presented after a while.

Regression Range
Last good revision: 55f5d719d0359a35443d0d2586af7383645a94b6 (2019-09-24)
First bad revision: 15ffd69c83be752a28fc40a5db6b6859452fa41f (2019-09-25)
Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=55f5d719d0359a35443d0d2586af7383645a94b6&tochange=15ffd69c83be752a28fc40a5db6b6859452fa41f
Possible regressor bug 1582797.

Notes

• Attached a screen recording.

Comment 1

[Alexandru Trif, Desktop QA [:atrif]]

Sorry, I miss clicked the flags.

Comment 2

[Alexandru Trif, Desktop QA [:atrif]]

Attachment: console-export-2020-5-4_16-19-26.txt

Also when this error is presented after clicking Stop script on the error from comment 0 the attached message is shown in the browser console.

Comment 3

[:Gijs (he/him)]

Dão, can you take a look? Are we getting resize events from the wrong code, or is the popuphidden/popupshown code added in https://phabricator.services.mozilla.com/D46624#C1630552NL4892 perhaps firing for the autocomplete popup from the search widget and interfering with things that way, or something?