1635109 - Cleanups in JS::CompileOptions

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Ted Campbell [:tcampbell]]

There are a few more options that should be moved to the TransitiveCompileOptions and some basic dead code removal.

Comment 1

[Ted Campbell [:tcampbell]]

Attachment: Bug 1635109 - Move more options to TransitiveCompileOptions. r?caroline

The nonSyntacticScope and skipFilenameValidation options do not vary
throughout compilation so they should be TransitiveCompileOptions.

Comment 2

[Ted Campbell [:tcampbell]]

Attachment: Bug 1635109 - Cleanup CompileOptions constructors. r?caroline

Remove (unused) ability to clone TransitiveCompileOptions& since we now
expect these options to no long vary within a compilation. The only cloning
of CompileOptions should be of the complete ReadOnlyCompileOptions set in
order to make adjustments before the compile starts.

Depends on D73694

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0cbe127cb0cc
Move more options to TransitiveCompileOptions. r=caroline
https://hg.mozilla.org/integration/autoland/rev/fc86233b13b7
Cleanup CompileOptions constructors. r=caroline

Comment 4

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/0cbe127cb0cc
https://hg.mozilla.org/mozilla-central/rev/fc86233b13b7