1635115 - Initialize "input" ImmutableScriptFlags in SharedContext

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Description

[Ted Campbell [:tcampbell]]

Ensure that all the "input" flags are initialized in SharedContext constructor. This provides a more consistent definition throughout frontend.

Comment 1

[Ted Campbell [:tcampbell]]

Attachment: Bug 1635115 - Initialize "input" ImmutableFlags in SharedContext constructor. r?mgaudet

This removes all other locations through the frontend where these flags would
be set. The transitive options are applied to all SharedContext, while the
non-transitive flags are only applied to top-level (non-function)
SharedContext. Also update frontend to stop reading these CompileOptions
flags directly and instead rely on the SharedContext::immutableFlags.

Depends on D73695

Comment 2

[Ted Campbell [:tcampbell]]

Attachment: Bug 1635115 - Inline SourceAwareCompiler::prepareScriptParse and friends. r?mgaudet

As we progress towards Stencil, these "prepare" abstractions make less sense
as their original purpose was to allocate GC-things.

Depends on D73696

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f19716c861d3
Initialize "input" ImmutableFlags in SharedContext constructor. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/6932cdaa9e76
Inline SourceAwareCompiler::prepareScriptParse and friends. r=mgaudet

Comment 4

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/f19716c861d3
https://hg.mozilla.org/mozilla-central/rev/6932cdaa9e76